4 years, 10 months ago
(2016-02-09 18:58:31 UTC)
#1
Created Revert of Implement ChromeVox Next menus.
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/1
4 years, 10 months ago
(2016-02-09 19:04:06 UTC)
#2
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/113596) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago
(2016-02-09 19:10:24 UTC)
#4
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago
(2016-02-09 19:15:54 UTC)
#6
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144307)
4 years, 10 months ago
(2016-02-09 19:38:11 UTC)
#8
Description was changed from ========== Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of ...
4 years, 10 months ago
(2016-02-09 19:38:28 UTC)
#9
Description was changed from
==========
Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of
https://codereview.chromium.org/1561773002/ )
Reason for revert:
Speculatively reverting to fix interactive_ui_test failures starting here:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1
This patch was committed in the preceding build (here) but the flake wasn't
detected until the next build.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
Original issue's description:
> Implement ChromeVox Next menus.
>
> Open the menus by pressing Search+Period or by clicking on the icon in the
> panel. Select an item with the mouse or arrow keys.
>
> Everything with a key binding and category appears in the menus by default.
> Also adds all open tabs to the menus.
>
> The feedback when the menu first opens isn't always right, this will be
> fixed when we get better focus tracking.
>
> BUG=513717
>
> Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
> Cr-Commit-Position: refs/heads/master@{#373852}
TBR=dtseng@chromium.org,plundblad@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=513717
==========
to
==========
Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of
https://codereview.chromium.org/1561773002/ )
Reason for revert:
Speculatively reverting to fix interactive_ui_test failures starting here:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1
This patch was committed in the preceding build (here) but the flake wasn't
detected until the next build.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
Original issue's description:
> Implement ChromeVox Next menus.
>
> Open the menus by pressing Search+Period or by clicking on the icon in the
> panel. Select an item with the mouse or arrow keys.
>
> Everything with a key binding and category appears in the menus by default.
> Also adds all open tabs to the menus.
>
> The feedback when the menu first opens isn't always right, this will be
> fixed when we get better focus tracking.
>
> BUG=513717
>
> Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
> Cr-Commit-Position: refs/heads/master@{#373852}
TBR=dtseng@chromium.org,plundblad@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=513717
NOPRESUBMIT=true
==========
tommycli
The CQ bit was checked by tommycli@chromium.org
4 years, 10 months ago
(2016-02-09 19:39:38 UTC)
#10
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago
(2016-02-09 19:41:22 UTC)
#11
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/19541) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago
(2016-02-09 20:08:56 UTC)
#13
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago
(2016-02-09 20:26:30 UTC)
#15
Description was changed from ========== Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of ...
4 years, 10 months ago
(2016-02-09 20:56:02 UTC)
#16
Message was sent while issue was closed.
Description was changed from
==========
Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of
https://codereview.chromium.org/1561773002/ )
Reason for revert:
Speculatively reverting to fix interactive_ui_test failures starting here:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1
This patch was committed in the preceding build (here) but the flake wasn't
detected until the next build.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
Original issue's description:
> Implement ChromeVox Next menus.
>
> Open the menus by pressing Search+Period or by clicking on the icon in the
> panel. Select an item with the mouse or arrow keys.
>
> Everything with a key binding and category appears in the menus by default.
> Also adds all open tabs to the menus.
>
> The feedback when the menu first opens isn't always right, this will be
> fixed when we get better focus tracking.
>
> BUG=513717
>
> Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
> Cr-Commit-Position: refs/heads/master@{#373852}
TBR=dtseng@chromium.org,plundblad@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=513717
NOPRESUBMIT=true
==========
to
==========
Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of
https://codereview.chromium.org/1561773002/ )
Reason for revert:
Speculatively reverting to fix interactive_ui_test failures starting here:
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1
This patch was committed in the preceding build (here) but the flake wasn't
detected until the next build.
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20...
Original issue's description:
> Implement ChromeVox Next menus.
>
> Open the menus by pressing Search+Period or by clicking on the icon in the
> panel. Select an item with the mouse or arrow keys.
>
> Everything with a key binding and category appears in the menus by default.
> Also adds all open tabs to the menus.
>
> The feedback when the menu first opens isn't always right, this will be
> fixed when we get better focus tracking.
>
> BUG=513717
>
> Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c
> Cr-Commit-Position: refs/heads/master@{#373852}
TBR=dtseng@chromium.org,plundblad@chromium.org,dmazzoni@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=513717
NOPRESUBMIT=true
==========
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 10 months ago
(2016-02-09 20:56:03 UTC)
#17
Message was sent while issue was closed.
Committed patchset #2 (id:270001)
commit-bot: I haz the power
Description was changed from ========== Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of ...
4 years, 10 months ago
(2016-02-09 20:58:23 UTC)
#18
Issue 1684693002: Revert of Implement ChromeVox Next menus.
(Closed)
Created 4 years, 10 months ago by tommycli
Modified 4 years, 10 months ago
Reviewers: David Tseng, Peter Lundblad, dmazzoni
Base URL: https://chromium.googlesource.com/chromium/src.git@panel_view_type
Comments: 0