Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1684693002: Revert of Implement ChromeVox Next menus. (Closed)

Created:
4 years, 10 months ago by tommycli
Modified:
4 years, 10 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@panel_view_type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement ChromeVox Next menus. (patchset #6 id:100001 of https://codereview.chromium.org/1561773002/ ) Reason for revert: Speculatively reverting to fix interactive_ui_test failures starting here: https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7059 TestAsNormalAndGuestUser_SpokenFeedbackTest.NavigateAppLauncher_1 This patch was committed in the preceding build (here) but the flake wasn't detected until the next build. https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20ChromeOS%20MSan%20Tests/builds/7058 Original issue's description: > Implement ChromeVox Next menus. > > Open the menus by pressing Search+Period or by clicking on the icon in the > panel. Select an item with the mouse or arrow keys. > > Everything with a key binding and category appears in the menus by default. > Also adds all open tabs to the menus. > > The feedback when the menu first opens isn't always right, this will be > fixed when we get better focus tracking. > > BUG=513717 > > Committed: https://crrev.com/429446698446a103171801d827c5dab5f98baa1c > Cr-Commit-Position: refs/heads/master@{#373852} TBR=dtseng@chromium.org,plundblad@chromium.org,dmazzoni@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=513717 NOPRESUBMIT=true Committed: https://crrev.com/fddea70c224828517eb6b3e9b7a59bbc3b38b043 Cr-Commit-Position: refs/heads/master@{#374463}

Patch Set 1 #

Patch Set 2 : generating revert using git #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -1084 lines) Patch
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/keymaps/next_keymap.json View 12 chunks +11 lines, -66 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/console_tts.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/injected/history.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store.js View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/command_store_test.unitjs View 1 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/common/composite_tts.js View 1 1 chunk +2 lines, -13 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 1 15 chunks +31 lines, -124 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs View 1 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs View 1 1 chunk +7 lines, -8 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.css View 1 chunk +0 lines, -206 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html View 3 chunks +103 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 5 chunks +11 lines, -361 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_command.js View 1 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu.js View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_menu_item.js View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 1 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/abstract_tts.js View 1 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/interface/tts_interface.js View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/manifest.json.jinja2 View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd View 1 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (9 generated)
tommycli
Created Revert of Implement ChromeVox Next menus.
4 years, 10 months ago (2016-02-09 18:58:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/1
4 years, 10 months ago (2016-02-09 19:04:06 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/113596) chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 10 months ago (2016-02-09 19:10:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago (2016-02-09 19:15:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/144307)
4 years, 10 months ago (2016-02-09 19:38:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago (2016-02-09 19:41:22 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/19541) android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-09 20:08:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684693002/270001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684693002/270001
4 years, 10 months ago (2016-02-09 20:26:30 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:270001)
4 years, 10 months ago (2016-02-09 20:56:03 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 20:58:24 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fddea70c224828517eb6b3e9b7a59bbc3b38b043
Cr-Commit-Position: refs/heads/master@{#374463}

Powered by Google App Engine
This is Rietveld 408576698