Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issue 16846002: MIPS: Allow the deoptimizer translation to track de-materialized objects. (Closed)

Created:
7 years, 6 months ago by kilvadyb
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Allow the deoptimizer translation to track de-materialized objects. Port r15087 (63e1626) Original commit message: This allows the deoptimizer to materialize objects (e.g. the arguments object) while deopting without having a consective stack area holding the object values. The LEnvironment explicitly tracks locations for these values and preserves them in the translation. TEST=mjsunit/compiler/inline-arguments BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -68 lines) Patch
M src/mips/lithium-codegen-mips.h View 2 chunks +2 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 7 chunks +31 lines, -58 lines 0 comments Download
M src/mips/lithium-mips.cc View 3 chunks +20 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kilvadyb
7 years, 6 months ago (2013-06-12 20:19:21 UTC) #1
Michael Starzinger
LGTM.
7 years, 6 months ago (2013-06-12 20:36:00 UTC) #2
Paul Lind
Thanks, Michael, LGTM to me too :-)
7 years, 6 months ago (2013-06-12 20:38:24 UTC) #3
palfia
Committed as r15097.
7 years, 6 months ago (2013-06-12 21:47:31 UTC) #4
Michael Starzinger
7 years, 6 months ago (2013-06-13 11:11:32 UTC) #5
This has been commited as https://code.google.com/p/v8/source/detail?r=15097 and
I am closing it to get it off my list.

Powered by Google App Engine
This is Rietveld 408576698