Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1684443002: flip_server: rename create_listener.* for clarity (Closed)

Created:
4 years, 10 months ago by tfarina
Modified:
4 years, 10 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

flip_server: rename create_listener.* for clarity This patch renames create_listener.* to tcp_socket_util.* as it is really a collection of tcp helper functions. While at it also rename the functions CreateListeningSocket and CreateConnectedSocket, to CreateTCPServerSocket and CreateTCPClientSocket respectively. As the pair Server/Client is much more common and easier to read/understand in the call sites than Connected for example and add TCP to make it clear that they create tcp sockets rather than udp or unix domain sockets for example. BUG=None R=rch@chromium.org Committed: https://crrev.com/fb3c78c8b983837cf26779e41b8a8464f630b8e6 Cr-Commit-Position: refs/heads/master@{#374495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -353 lines) Patch
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M net/net.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
D net/tools/flip_server/create_listener.h View 1 chunk +0 lines, -54 lines 0 comments Download
D net/tools/flip_server/create_listener.cc View 1 chunk +0 lines, -281 lines 0 comments Download
M net/tools/flip_server/flip_config.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/flip_server/sm_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + net/tools/flip_server/tcp_socket_util.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + net/tools/flip_server/tcp_socket_util.cc View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tfarina
Hi Ryan, could you review this to me?
4 years, 10 months ago (2016-02-08 23:24:54 UTC) #1
Ryan Hamilton
lgtm
4 years, 10 months ago (2016-02-08 23:51:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684443002/1
4 years, 10 months ago (2016-02-09 20:45:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 22:13:59 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 22:15:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fb3c78c8b983837cf26779e41b8a8464f630b8e6
Cr-Commit-Position: refs/heads/master@{#374495}

Powered by Google App Engine
This is Rietveld 408576698