Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1555)

Unified Diff: dart/pkg/lk/lib/leds.dart

Issue 1684433003: Add a small LED interface and demo app. (Closed) Base URL: git@github.com:domokit/sod.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/pkg/lk/lib/leds.dart
diff --git a/dart/pkg/lk/lib/leds.dart b/dart/pkg/lk/lib/leds.dart
new file mode 100644
index 0000000000000000000000000000000000000000..cb605a56151f762fe840eb250cc3f7c1c6fa538a
--- /dev/null
+++ b/dart/pkg/lk/lib/leds.dart
@@ -0,0 +1,22 @@
+// Copyright (c) 2016, the SoD project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE.md file.
+
+import 'dart:dartino.ffi';
+
+final ForeignFunction _toggleLED = ForeignLibrary.main.lookup('led_toggle');
+
+class LED {
+ final int _id;
+
+ const LED._internal(this._id);
lukechurch 2016/02/09 09:20:01 Consider an explanatory comment as to the pattern
herhut 2016/02/09 10:10:15 I think this is a very common pattern and we shoul
lukechurch 2016/02/09 10:13:53 I agree. We should describe it once, in the place
+
+ setState(bool value) {
Søren Gjesse 2016/02/09 09:16:01 Just make this a setter. And please add a getter
herhut 2016/02/09 10:10:15 Done.
+ _toggleLED.icall$2(_id, value ? 1 : 0);
+ }
+}
+
+const LED0 = const LED._internal(0);
+const LED1 = const LED._internal(1);
+const LED2 = const LED._internal(2);
+const LED3 = const LED._internal(3);

Powered by Google App Engine
This is Rietveld 408576698