src/views/win/SkOSWindow_win.cpp - Issue 1684413003: Implement support for using GL ES 3.0 with command buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/views/win/SkOSWindow_win.cpp

Issue 1684413003: Implement support for using GL ES 3.0 with command buffer (Closed) Base URL: https://skia.googlesource.com/skia.git@no-texture-rectangle-gles

Patch Set: egl destruction update Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp ('K') | « src/gpu/gl/command_buffer/SkCommandBufferGLContext.cpp ('k') | tests/TestConfigParsing.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/views/win/SkOSWindow_win.cpp

diff --git a/src/views/win/SkOSWindow_win.cpp b/src/views/win/SkOSWindow_win.cpp

index 4b7abb1e96686cbb510b7282c7b83eccdbb65cc7..707f1eceb0028ed20ed2fc125650e5df78415057 100644

--- a/src/views/win/SkOSWindow_win.cpp

+++ b/src/views/win/SkOSWindow_win.cpp

@@ -617,7 +617,7 @@ bool SkOSWindow::attach(SkBackEndTypes attachType, int msaaSampleCount, Attachme

break;

#endif // SK_ANGLE

#if SK_COMMAND_BUFFER

- case kCommandBuffer_BackEndType:

+ case kCommandBufferES2_BackEndType:

result = attachCommandBuffer(msaaSampleCount, info);

break;

#endif // SK_COMMAND_BUFFER

@@ -650,7 +650,7 @@ void SkOSWindow::detach() {

break;

#endif // SK_ANGLE

#if SK_COMMAND_BUFFER

- case kCommandBuffer_BackEndType:

+ case kCommandBufferES2_BackEndType:

detachCommandBuffer();

break;

#endif // SK_COMMAND_BUFFER

@@ -677,7 +677,7 @@ void SkOSWindow::present() {

break;

#endif // SK_ANGLE

#if SK_COMMAND_BUFFER

- case kCommandBuffer_BackEndType:

+ case kCommandBufferES2_BackEndType:

presentCommandBuffer();

break;

#endif // SK_COMMAND_BUFFER