src/gpu/GrContextFactory.h - Issue 1684413003: Implement support for using GL ES 3.0 with command buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrContextFactory.h

Issue 1684413003: Implement support for using GL ES 3.0 with command buffer (Closed) Base URL: https://skia.googlesource.com/skia.git@no-texture-rectangle-gles

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« include/gpu/gl/command_buffer/SkCommandBufferGLContext.h ('K') | « include/gpu/gl/command_buffer/SkCommandBufferGLContext.h ('k') | src/gpu/GrContextFactory.cpp » ('j') | src/gpu/gl/GrGLCaps.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/gpu/GrContextFactory.h

diff --git a/src/gpu/GrContextFactory.h b/src/gpu/GrContextFactory.h

index 7afa3108c69d8984e0d63cd76350570dc764d4be..b29acc55483e1d270d55cca09ae0d86097be7f3a 100644

--- a/src/gpu/GrContextFactory.h

+++ b/src/gpu/GrContextFactory.h

@@ -35,6 +35,8 @@ public:

#endif

#if SK_COMMAND_BUFFER

kCommandBuffer_GLContextType, //! Chromium command buffer OpenGL ES context.

bsalomon 2016/02/12 14:03:27 Can we rename this CommandBufferES2?

Kimmo Kinnunen 2016/02/15 08:10:14 Done.

+ kCommandBufferES3_GLContextType, //! Chromium command buffer OpenGL ES 3.0 context.

+ //! Not ready for production.

#endif

#if SK_MESA

kMESA_GLContextType, //! MESA OpenGL context

@@ -84,6 +86,8 @@ public:

#if SK_COMMAND_BUFFER

case kCommandBuffer_GLContextType:

return "commandbuffer";

+ case kCommandBufferES3_GLContextType:

+ return "commandbuffer3";

#endif

#if SK_MESA

case kMESA_GLContextType: