Implement support for using GL ES 3.0 with command buffer

src/gpu/gl/GrGLInterface.cpp

 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "gl/GrGLInterface.h"
 #include "gl/GrGLExtensions.h"
@@ skipping 198 matching lines @@
         nullptr == fFunctions.fGenFramebuffers ||
         nullptr == fFunctions.fGenRenderbuffers ||
         nullptr == fFunctions.fRenderbufferStorage) {
         RETURN_FALSE_INTERFACE
     }
 
     GrGLVersion glVer = GrGLGetVersion(this);
     if (GR_GL_INVALID_VER == glVer) {
         RETURN_FALSE_INTERFACE
     }
+    // TODO: Remove this once command buffer implements full ES3.
+    GrGLDriver glDriver = kUnknown_GrGLDriver;

[bsalomon, 2016/02/12 14:03:27]

Similar request to above, instead of storing a driver var, can we have a bool
that indicates these are workarounds for command buffer issues.

e.g.

if (0 == strcmp(renderer, "Chromium")) {
   ALLOW_MISSING_FUNCTIONS_FOR_INCOMPLETE_CMD_BUFFER_ES3 = true;
}

[Kimmo Kinnunen, 2016/02/15 08:10:14]

Done.

+    if (kGLES_GrGLStandard == fStandard) {
+        const GrGLubyte* rendererUByte;
+        GR_GL_CALL_RET(this, rendererUByte, GetString(GR_GL_RENDERER));
+        const char* renderer = reinterpret_cast<const char*>(rendererUByte);
+        if (0 == strcmp(renderer, "Chromium")) {
+            glDriver = kChromium_GrGLDriver;
+        }
+    }
 
     // Now check that baseline ES/Desktop fns not covered above are present
     // and that we have fn pointers for any advertised fExtensions that we will
     // try to use.
 
     // these functions are part of ES2, we assume they are available
     // On the desktop we assume they are available if the extension
     // is present or GL version is high enough.
     if (kGLES_GrGLStandard == fStandard) {
         if (nullptr == fFunctions.fStencilFuncSeparate ||
@@ skipping 70 matching lines @@
     // There is a desktop ARB extension and an ES+desktop EXT extension
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(4,2) ||
             fExtensions.has("GL_ARB_texture_storage") ||
             fExtensions.has("GL_EXT_texture_storage")) {
             if (nullptr == fFunctions.fTexStorage2D) {
                 RETURN_FALSE_INTERFACE
             }
         }
     } else if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_texture_storage")) {
-        if (nullptr == fFunctions.fTexStorage2D) {
-            RETURN_FALSE_INTERFACE
+        // TODO: remove once command buffer implements full ES3.
+        if (kChromium_GrGLDriver != glDriver) {
+            if (nullptr == fFunctions.fTexStorage2D) {
+                RETURN_FALSE_INTERFACE
+            }
         }
     }
 
     // glTextureBarrier is part of desktop 4.5. There are also ARB and NV extensions.
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(4,5) ||
             fExtensions.has("GL_ARB_texture_barrier") ||
             fExtensions.has("GL_NV_texture_barrier")) {
             if (nullptr == fFunctions.fTextureBarrier) {
                 RETURN_FALSE_INTERFACE
@@ skipping 152 matching lines @@
             nullptr == fFunctions.fUnmapBufferSubData ||
             nullptr == fFunctions.fUnmapTexSubImage2D) {
             RETURN_FALSE_INTERFACE;
         }
     }
 
     // These functions are added to the 3.0 version of both GLES and GL.
     if (glVer >= GR_GL_VER(3,0) ||
         (kGLES_GrGLStandard == fStandard && fExtensions.has("GL_EXT_map_buffer_range")) ||
         (kGL_GrGLStandard == fStandard && fExtensions.has("GL_ARB_map_buffer_range"))) {
-        if (nullptr == fFunctions.fMapBufferRange ||
-            nullptr == fFunctions.fFlushMappedBufferRange) {
-            RETURN_FALSE_INTERFACE;
+        // TODO: remove once command buffer implements full ES3.
+        if (kChromium_GrGLDriver != glDriver) {
+            if (nullptr == fFunctions.fMapBufferRange ||
+                nullptr == fFunctions.fFlushMappedBufferRange) {
+                RETURN_FALSE_INTERFACE;
+            }
         }
     }
 
     if ((kGL_GrGLStandard == fStandard &&
          (glVer >= GR_GL_VER(4,3) || fExtensions.has("GL_ARB_program_interface_query"))) ||
         (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1))) {
         if (nullptr == fFunctions.fGetProgramResourceLocation) {
             RETURN_FALSE_INTERFACE
         }
     }
@@ skipping 59 matching lines @@
         }
     }
 
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(3,1) ||
             fExtensions.has("GL_EXT_draw_instanced") || fExtensions.has("GL_ARB_draw_instanced")) {
             if (nullptr == fFunctions.fDrawArraysInstanced ||
                 nullptr == fFunctions.fDrawElementsInstanced) {
                 RETURN_FALSE_INTERFACE
             }
-        }    
+        }
     } else if (kGLES_GrGLStandard == fStandard) {
-        if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_draw_instanced")) {
-            if (nullptr == fFunctions.fDrawArraysInstanced ||
-                nullptr == fFunctions.fDrawElementsInstanced) {
-                RETURN_FALSE_INTERFACE
+        // TODO: remove once command buffer implements full ES3.
+        if (kChromium_GrGLDriver != glDriver) {
+            if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_draw_instanced")) {
+                if (nullptr == fFunctions.fDrawArraysInstanced ||
+                    nullptr == fFunctions.fDrawElementsInstanced) {
+                    RETURN_FALSE_INTERFACE
+                }
             }
-        }    
+        }
     }
 
     if (kGL_GrGLStandard == fStandard) {
         if (glVer >= GR_GL_VER(3,2) || fExtensions.has("GL_ARB_instanced_arrays")) {
             if (nullptr == fFunctions.fVertexAttribDivisor) {
                 RETURN_FALSE_INTERFACE
             }
-        }    
+        }
     } else if (kGLES_GrGLStandard == fStandard) {
-        if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_instanced_arrays")) {
-            if (nullptr == fFunctions.fVertexAttribDivisor) {
-                RETURN_FALSE_INTERFACE
+        // TODO: remove once command buffer implements full ES3.
+        if (kChromium_GrGLDriver != glDriver) {
+            if (glVer >= GR_GL_VER(3,0) || fExtensions.has("GL_EXT_instanced_arrays")) {
+                if (nullptr == fFunctions.fVertexAttribDivisor) {
+                    RETURN_FALSE_INTERFACE
+                }
             }
-        }    
+        }
     }
 
     if ((kGL_GrGLStandard == fStandard && glVer >= GR_GL_VER(4,3)) ||
         (kGLES_GrGLStandard == fStandard && glVer >= GR_GL_VER(3,1))) {
         if (NULL == fFunctions.fDrawArraysIndirect ||
             NULL == fFunctions.fDrawElementsIndirect) {
             RETURN_FALSE_INTERFACE
         }
     }
 
@@ skipping 158 matching lines @@
 
     if (fExtensions.has("EGL_KHR_image") || fExtensions.has("EGL_KHR_image_base")) {
         if (nullptr == fFunctions.fEGLCreateImage ||
             nullptr == fFunctions.fEGLDestroyImage) {
             RETURN_FALSE_INTERFACE
         }
     }
 
     return true;
 }