Issue 16844021: Rewrite scoped_ptr<T>(NULL) to use the default ctor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16844021: Rewrite scoped_ptr<T>(NULL) to use the default ctor. (Closed)

Created:
7 years, 6 months ago by dcheng

Modified:
7 years, 6 months ago

Reviewers:
tapted, Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, tfarina, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, chromium-apps-reviews_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rewrite scoped_ptr<T>(NULL) to use the default ctor. This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on Mac. BUG=173286 R=tapted@chromium.org, wez@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206406

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	apps/app_shim/app_shim_host_mac.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
	M	remoting/host/audio_capturer_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dcheng

7 years, 6 months ago (2013-06-14 13:03:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r206406 (presubmit successful).

Expand Messages | Collapse Messages