app_mode: Add runtime.onRestartRequired event.

chrome/browser/extensions/api/runtime/runtime_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/runtime/runtime_api.h"
 
+#include <utility>
+
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/extensions/event_router.h"
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/lazy_background_task_queue.h"
 #include "chrome/browser/extensions/updater/extension_updater.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 12 matching lines @@
 
 namespace extensions {
 
 namespace {
 
 const char kOnStartupEvent[] = "runtime.onStartup";
 const char kOnInstalledEvent[] = "runtime.onInstalled";
 const char kOnUpdateAvailableEvent[] = "runtime.onUpdateAvailable";
 const char kOnBrowserUpdateAvailableEvent[] =
     "runtime.onBrowserUpdateAvailable";
+const char kOnRestartRequiredEvent[] = "runtime.onRestartRequired";
 const char kNoBackgroundPageError[] = "You do not have a background page.";
 const char kPageLoadError[] = "Background page failed to load.";
 const char kInstallReason[] = "reason";
 const char kInstallReasonChromeUpdate[] = "chrome_update";
 const char kInstallReasonUpdate[] = "update";
 const char kInstallReasonInstall[] = "install";
 const char kInstallPreviousVersion[] = "previousVersion";
 const char kInvalidUrlError[] = "Invalid URL.";
+const char kRestartReason[] = "reason";
+const char kRestartReasonAppUpdate[] = "app_update";
+const char kRestartReasonOsUpdate[] = "os_update";
+const char kRestartReasonPeriodic[] = "periodic";
 const char kUpdatesDisabledError[] = "Autoupdate is not enabled.";
 const char kUpdateFound[] = "update_available";
 const char kUpdateNotFound[] = "no_update";
 const char kUpdateThrottled[] = "throttled";
 
 // A preference key storing the url loaded when an extension is uninstalled.
 const char kUninstallUrl[] = "uninstall_url";
 
 static void DispatchOnStartupEventImpl(
     Profile* profile,
@@ skipping 118 matching lines @@
     return;
 
   scoped_ptr<ListValue> args(new ListValue);
   DCHECK(system->event_router());
   scoped_ptr<Event> event(new Event(kOnBrowserUpdateAvailableEvent,
                                     args.Pass()));
   system->event_router()->BroadcastEvent(event.Pass());
 }
 
 // static
+void RuntimeEventRouter::DispatchOnRestartRequiredEvent(
+    Profile* profile,
+    const std::string& app_id,
+    RestartReason reason) {
+  ExtensionSystem* system = ExtensionSystem::Get(profile);
+  if (!system)
+    return;
+
+  scoped_ptr<ListValue> args(new ListValue);

[bartfab (slow), 2013/06/17 23:30:59]

Nit: #include <base/values.h>

[xiyuan, 2013/06/20 02:17:12]

Done.

+  switch (reason) {
+    case RESTART_REASON_APP_UPDATE:
+      args->AppendString(kRestartReasonAppUpdate);
+      break;
+    case RESTART_REASON_OS_UPDATE:
+      args->AppendString(kRestartReasonOsUpdate);
+      break;
+    case RESTART_REASON_PERIODIC:
+      args->AppendString(kRestartReasonPeriodic);
+      break;
+  }

[bartfab (slow), 2013/06/17 23:30:59]

Nit: Add a fallback with a DCHECK() for invalid |reason|s.

[xiyuan, 2013/06/20 02:17:12]

Done.

+
+  DCHECK(system->event_router());

[bartfab (slow), 2013/06/17 23:30:59]

Nit: Include <base/logging.h>

[xiyuan, 2013/06/20 02:17:12]

Done.

+  scoped_ptr<Event> event(new Event(kOnRestartRequiredEvent, args.Pass()));
+  system->event_router()->DispatchEventToExtension(app_id, event.Pass());
+}
+
+// static
 void RuntimeEventRouter::OnExtensionUninstalled(
-    Profile *profile,
+    Profile* profile,
     const std::string& extension_id) {
 #if defined(ENABLE_EXTENSIONS)
   GURL uninstall_url(GetUninstallUrl(ExtensionPrefs::Get(profile),
                                      extension_id));
 
   if (uninstall_url.is_empty())
     return;
 
   Browser* browser = chrome::FindLastActiveWithProfile(profile,
       chrome::GetActiveDesktop());
@@ skipping 177 matching lines @@
   } else {
     NOTREACHED();
     return false;
   }
 
   results_ = GetPlatformInfo::Results::Create(info);
   return true;
 }
 
 }   // namespace extensions