Stop building DumpRenderTree and delete the files.

Stop building DumpRenderTree and delete the files.

It is no longer very useful and is no longer run anywhere by default.

R=jamesr@chromium.org, jochen@chromium.org, peter@chromium.org
BUG=244560
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=152593

[Dirk Pranke, 2013-06-12 20:55:08]

Peter, can you confirm that this is ok for Android?

[jamesr, 2013-06-12 20:56:35]

lgtm

[jochen (gone - plz use gerrit), 2013-06-13 07:42:13]

I think clusterfuzz still runs DRT, no?

[inferno, 2013-06-13 14:22:30]

On 2013/06/13 07:42:13, jochen wrote:
> I think clusterfuzz still runs DRT, no?

i moved off clusterfuzz yesterday. we would miss drt though since it was very
fast and less memory intensive than content shell, so we were squeezing it far
more instances for fuzzing.

[Peter Beverloo, 2013-06-14 12:39:37]

After asking a bunch of people, no one seems to be using DRT for Android
anymore, and content_shell is making good progress.  While I'm not in a hurry in
getting DRT removed, there is no reason to block this on Android.

lgtm!  Awesome to see this happening, thanks so much!

[jochen (gone - plz use gerrit), 2013-06-17 08:27:03]

lgtm

[commit-bot: I haz the power, 2013-06-17 19:50:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/16844004/1

[commit-bot: I haz the power, 2013-06-17 19:50:19]

Failed to apply patch for
Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
  Hunk #2 FAILED at 267.
  1 out of 3 hunks FAILED -- saving rejects to file
Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp.rej

Patch:       Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
Index: Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
diff --git a/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
b/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
index
b1e9c08aff8a78934ff5efb1f050183f5345e13e..08491923911158f35ab1f788bf2cdc4e5070d759
100644
--- a/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
+++ b/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp
@@ -150,6 +150,46 @@
             'msvs_disabled_warnings': [ 4267, ],
         },
         {
+            # FIXME: This is only used by webkit_unit_tests now, move it to
WebKitUnitTests.gyp.
+            'target_name': 'DumpRenderTree_resources',
+            'type': 'none',
+            'dependencies': [
+                '<(DEPTH)/net/net.gyp:net_resources',
+                '<(DEPTH)/ui/ui.gyp:ui_resources',
+                '<(DEPTH)/webkit/support/webkit_support.gyp:webkit_resources',
+                '<(DEPTH)/webkit/support/webkit_support.gyp:webkit_strings',
+            ],
+            'actions': [{
+                'action_name': 'repack_local',
+                'variables': {
+                    'repack_path': '<(DEPTH)/tools/grit/grit/format/repack.py',
+                    'pak_inputs': [
+                        '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
+                        '<(SHARED_INTERMEDIATE_DIR)/ui/gfx/gfx_resources.pak',
+                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
+                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.pak',
+                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
+                ]},
+                'inputs': [
+                    '<(repack_path)',
+                    '<@(pak_inputs)',
+                ],
+                'outputs': [
+                    '<(PRODUCT_DIR)/DumpRenderTree.pak',
+                ],
+                'action': ['python', '<(repack_path)', '<@(_outputs)',
'<@(pak_inputs)'],
+            }],
+            'conditions': [
+                ['OS=="mac"', {
+                    'all_dependent_settings': {
+                        'mac_bundle_resources': [
+                            '<(PRODUCT_DIR)/DumpRenderTree.pak',
+                        ],
+                    },
+                }],
+            ]
+        },
+        {
             'target_name': 'TestRunner_resources',
             'type': 'none',
             'dependencies': [
@@ -227,176 +267,6 @@
             ],
         },
         {
-            'target_name': 'DumpRenderTree',
-            'type': 'executable',
-            'mac_bundle': 1,
-            'dependencies': [
-                'TestRunner',
-                'DumpRenderTree_resources',
-                '../../../public/blink.gyp:blink',
-               
'<(source_dir)/devtools/devtools.gyp:devtools_frontend_resources',
-                '<(source_dir)/wtf/wtf.gyp:wtf',
-                '<(DEPTH)/base/base.gyp:test_support_base',
-                '<(DEPTH)/build/temp_gyp/googleurl.gyp:googleurl',
-                '<(DEPTH)/third_party/icu/icu.gyp:icuuc',
-                '<(DEPTH)/third_party/mesa/mesa.gyp:osmesa',
-                '<(DEPTH)/v8/tools/gyp/v8.gyp:v8',
-                '<(DEPTH)/webkit/support/webkit_support.gyp:webkit_support',
-            ],
-            'include_dirs': [
-                '<(DEPTH)',
-                '<(source_dir)/WebKit/chromium/public',
-                '<(tools_dir)/DumpRenderTree',
-            ],
-            'defines': [
-                # Technically not a unit test but require functions available
only to
-                # unit tests.
-                'UNIT_TEST',
-            ],
-            'sources': [
-                '<@(drt_files)',
-            ],
-            'conditions': [
-                ['OS=="mac" or OS=="win" or toolkit_uses_gtk==1', {
-                    # These platforms have their own implementations of
-                    # checkLayoutTestSystemDependencies() and
openStartupDialog().
-                    'sources/': [
-                        ['exclude', 'TestShellStub\\.cpp$'],
-                    ],
-                }],
-                ['OS=="win"', {
-                    'dependencies': [
-                       
'<(DEPTH)/third_party/angle/src/build_angle.gyp:libEGL',
-                       
'<(DEPTH)/third_party/angle/src/build_angle.gyp:libGLESv2',
-                    ],
-                    'resource_include_dirs':
['<(SHARED_INTERMEDIATE_DIR)/webkit'],
-                    'sources': [
-                        # FIXME: We should just use the resources in the .pak
file.
-                        '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.rc',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.rc',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources.rc',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.rc',
-                    ],
-                    'configurations': {
-                        'Debug_Base': {
-                            'msvs_settings': {
-                                'VCLinkerTool': {
-                                    'LinkIncremental':
'<(msvs_large_module_debug_link_mode)',
-                                },
-                            },
-                        },
-                    },
-                },{ # OS!="win"
-                    'sources/': [
-                        ['exclude', 'Win\\.cpp$'],
-                    ],
-                }],
-                ['OS=="mac"', {
-                    'dependencies': [
-                        '<(source_dir)/WebKit/chromium/WebKit.gyp:copy_mesa',
-                    ],
-                },{ # OS!="mac"
-                    'sources/': [
-                        # .mm is already excluded by common.gypi
-                        ['exclude', 'Mac\\.cpp$'],
-                    ],
-                }],
-                ['os_posix!=1 or OS=="mac"', {
-                    'sources/': [
-                        ['exclude', 'Posix\\.cpp$'],
-                    ],
-                }],
-                ['use_x11 == 1', {
-                    'dependencies': [
-                        '<(DEPTH)/build/linux/system.gyp:fontconfig',
-                    ],
-                    'variables': {
-                        # FIXME: Enable warnings on other platforms.
-                        'chromium_code': 1,
-                    },
-                    'conditions': [
-                        ['linux_use_tcmalloc == 1', {
-                            'dependencies': [
-                               
'<(DEPTH)/base/allocator/allocator.gyp:allocator',
-                            ],
-                        }],
-                    ],
-                },{ # use_x11 != 1
-                    'sources/': [
-                        ['exclude', 'X11\\.cpp$'],
-                    ]
-                }],
-                ['toolkit_uses_gtk == 1', {
-                    'defines': [
-                        'WTF_USE_GTK=1',
-                    ],
-                    'dependencies': [
-                        '<(DEPTH)/build/linux/system.gyp:gtk',
-                    ],
-                    'include_dirs': [
-                        '<(source_dir)/WebKit/chromium/public/gtk',
-                    ],
-                }],
-                ['OS=="android"', {
-                    'type': 'shared_library',
-                    'dependencies': [
-                        '<(DEPTH)/base/base.gyp:test_support_base',
-                       
'<(DEPTH)/testing/android/native_test.gyp:native_test_native_code',
-                       
'<(DEPTH)/tools/android/forwarder/forwarder.gyp:forwarder',
-                        '<(DEPTH)/tools/android/md5sum/md5sum.gyp:md5sum',
-                    ],
-                }, { # OS!="android"
-                    'sources/': [
-                        ['exclude', 'Android\\.cpp$'],
-                    ],
-                }],
-                ['use_custom_freetype==1', {
-                   'dependencies': [
-                      
'<(DEPTH)/third_party/freetype2/freetype2.gyp:freetype2',
-                   ],
-                }],
-            ],
-        },
-        {
-            'target_name': 'DumpRenderTree_resources',
-            'type': 'none',
-            'dependencies': [
-                '<(DEPTH)/net/net.gyp:net_resources',
-                '<(DEPTH)/ui/ui.gyp:ui_resources',
-                '<(DEPTH)/webkit/support/webkit_support.gyp:webkit_resources',
-                '<(DEPTH)/webkit/support/webkit_support.gyp:webkit_strings',
-            ],
-            'actions': [{
-                'action_name': 'repack_local',
-                'variables': {
-                    'repack_path': '<(DEPTH)/tools/grit/grit/format/repack.py',
-                    'pak_inputs': [
-                        '<(SHARED_INTERMEDIATE_DIR)/net/net_resources.pak',
-                        '<(SHARED_INTERMEDIATE_DIR)/ui/gfx/gfx_resources.pak',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_chromium_resources.pak',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_strings_en-US.pak',
-                       
'<(SHARED_INTERMEDIATE_DIR)/webkit/webkit_resources_100_percent.pak',
-                ]},
-                'inputs': [
-                    '<(repack_path)',
-                    '<@(pak_inputs)',
-                ],
-                'outputs': [
-…
(message too large)

[commit-bot: I haz the power, 2013-06-17 20:04:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/16844004/10002

[commit-bot: I haz the power, 2013-06-17 21:19:42]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[Dirk Pranke, 2013-06-18 00:09:21]

Committed patchset #2 manually as r152593 (presubmit successful).