Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: tools/testing/dart/browser_controller.dart

Issue 16843009: Add timing information to browser controller logging. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/browser_controller.dart
===================================================================
--- tools/testing/dart/browser_controller.dart (revision 23949)
+++ tools/testing/dart/browser_controller.dart (working copy)
@@ -566,7 +566,8 @@
void handleResults(String browserId, String output, int testId) {
var status = browserStatus[browserId];
- DebugLogger.info("Handling result for browser ${browserId}");
+ DebugLogger.info("${new DateTime.now()}: Handling result for "
kustermann 2013/06/13 07:42:36 You should've put this 'new DateTime.now()' into o
+ "browser ${browserId}");
if (testCache.containsKey(testId)) {
doubleReportingTests.add(testId);
return;
@@ -602,7 +603,8 @@
void handleTimeout(BrowserTestingStatus status) {
// We simply kill the browser and starts up a new one!
// We could be smarter here, but it does not seems like it is worth it.
- DebugLogger.info("Handling timeout for browser ${status.browser.id}");
+ DebugLogger.info("${new DateTime.now()}: Handling timeout for "
+ "browser ${status.browser.id}");
status.timeout = true;
timedOut.add(status.currentTest.url);
var id = status.browser.id;
@@ -655,8 +657,8 @@
if (testQueue.isEmpty) return null;
var status = browserStatus[browserId];
if (status == null) return null;
- DebugLogger.info("Handling getNext for browser ${browserId}"
- " timeout status: ${status.timeout}");
+ DebugLogger.info("${new DateTime.now()}: Handling getNext for browser "
+ "${browserId} timeout status: ${status.timeout}");
// We are currently terminating this browser, don't start a new test.
if (status.timeout) return null;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698