Separate download cancel handling from download failure

Separate download cancel handling from download failure

Currently download cancel and download failure are treated in the
same way.
This causes the DownloadController to receive a download failure call
when cancelling a download.
And the DownloadNotificationService will show a failure
notification after user hit cancel button.
This CL splits download cancel from download failure.
So when user cancels a download, we won't show the failure notification.

BUG=579110
Committed: https://crrev.com/12a052769fd951ee7ae26c965933f14c33448c6f
Cr-Commit-Position: refs/heads/master@{#374802}

[qinmin, 2016-02-10 21:52:27]

qinmin@chromium.org changed reviewers:
+ tedchoc@chromium.org

[qinmin, 2016-02-10 21:52:28]

PTAL

[Ted C, 2016-02-10 23:20:25]

lgtm

[qinmin, 2016-02-10 23:21:07]

The CQ bit was checked by qinmin@chromium.org

[commit-bot: I haz the power, 2016-02-10 23:22:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684293002/1

[commit-bot: I haz the power, 2016-02-11 00:36:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-16 22:33:08]

Description was changed from

==========
Separate download cancel handling from download failure

Currently download cancel and download failure are treated in the
same way.
This causes the DownloadController to receive a download failure call
when cancelling a download.
And the DownloadNotificationService will show a failure
notification after user hit cancel button.
This CL splits download cancel from download failure.
So when user cancels a download, we won't show the failure notification.

BUG=579110
==========

to

==========
Separate download cancel handling from download failure

Currently download cancel and download failure are treated in the
same way.
This causes the DownloadController to receive a download failure call
when cancelling a download.
And the DownloadNotificationService will show a failure
notification after user hit cancel button.
This CL splits download cancel from download failure.
So when user cancels a download, we won't show the failure notification.

BUG=579110

Committed: https://crrev.com/12a052769fd951ee7ae26c965933f14c33448c6f
Cr-Commit-Position: refs/heads/master@{#374802}
==========

[commit-bot: I haz the power, 2016-02-16 22:33:10]

Patchset 1 (id:??) landed as
https://crrev.com/12a052769fd951ee7ae26c965933f14c33448c6f
Cr-Commit-Position: refs/heads/master@{#374802}