Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1684283002: Trace compilation during developer_extension_test. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/developer_extension_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index 1adcd6648b16315dcbefc256866e2f763fef144b..2091558500272e846d2800c0587792f87405b2ff 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -29,7 +29,8 @@ class _TestLauncher {
Future<int> launch(bool pause_on_start,
bool pause_on_exit,
bool pause_on_unhandled_exceptions,
- bool trace_service) {
+ bool trace_service,
+ bool trace_compiler) {
assert(pause_on_start != null);
assert(pause_on_exit != null);
assert(trace_service != null);
@@ -41,6 +42,9 @@ class _TestLauncher {
if (trace_service) {
fullArgs.add('--trace-service');
}
+ if (trace_compiler) {
+ fullArgs.add('--trace-compiler');
+ }
if (pause_on_start) {
fullArgs.add('--pause-isolates-on-start');
}
@@ -119,6 +123,7 @@ Future runIsolateTests(List<String> mainArgs,
bool pause_on_start: false,
bool pause_on_exit: false,
bool trace_service: false,
+ bool trace_compiler: false,
bool verbose_vm: false,
bool pause_on_unhandled_exceptions: false}) async {
assert(!pause_on_start || testeeBefore == null);
@@ -142,7 +147,8 @@ Future runIsolateTests(List<String> mainArgs,
} else {
var process = new _TestLauncher();
process.launch(pause_on_start, pause_on_exit,
- pause_on_unhandled_exceptions, trace_service).then((port) {
+ pause_on_unhandled_exceptions,
+ trace_service, trace_compiler).then((port) {
if (mainArgs.contains("--gdb")) {
port = 8181;
}
@@ -190,6 +196,7 @@ void runIsolateTestsSynchronous(List<String> mainArgs,
bool pause_on_start: false,
bool pause_on_exit: false,
bool trace_service: false,
+ bool trace_compiler: false,
bool verbose_vm: false,
bool pause_on_unhandled_exceptions: false}) {
assert(!pause_on_start || testeeBefore == null);
@@ -210,7 +217,8 @@ void runIsolateTestsSynchronous(List<String> mainArgs,
} else {
var process = new _TestLauncher();
process.launch(pause_on_start, pause_on_exit,
- pause_on_unhandled_exceptions, trace_service).then((port) {
+ pause_on_unhandled_exceptions,
+ trace_service, trace_compiler).then((port) {
if (mainArgs.contains("--gdb")) {
port = 8181;
}
@@ -400,6 +408,7 @@ Future runVMTests(List<String> mainArgs,
bool pause_on_start: false,
bool pause_on_exit: false,
bool trace_service: false,
+ bool trace_compiler: false,
bool verbose_vm: false,
bool pause_on_unhandled_exceptions: false}) async {
if (mainArgs.contains(_TESTEE_MODE_FLAG)) {
@@ -421,7 +430,7 @@ Future runVMTests(List<String> mainArgs,
process.launch(pause_on_start,
pause_on_exit,
pause_on_unhandled_exceptions,
- trace_service).then((port) async {
+ trace_service, trace_compiler).then((port) async {
if (mainArgs.contains("--gdb")) {
port = 8181;
}
« no previous file with comments | « runtime/observatory/tests/service/developer_extension_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698