Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1684233002: added SkDebugCanvas::toJSON (Closed)

Created:
4 years, 10 months ago by ethannicholas
Modified:
4 years, 10 months ago
Reviewers:
joshualitt, jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : constantified everything #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M tools/debugger/SkDebugCanvas.h View 2 chunks +7 lines, -0 lines 0 comments Download
M tools/debugger/SkDebugCanvas.cpp View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
ethannicholas
4 years, 10 months ago (2016-02-10 20:28:33 UTC) #3
joshualitt
On 2016/02/10 20:28:33, ethannicholas wrote: lgtm thanks!
4 years, 10 months ago (2016-02-10 20:29:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684233002/20001
4 years, 10 months ago (2016-02-10 20:30:13 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 20:57:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/402cd91f60bcf1a2f86f769bd02d79ace73770c9

Powered by Google App Engine
This is Rietveld 408576698