Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 168423003: Drop [LegacyImplementedInBaseClass] from AbstractWorker IDL interface (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, kinuko+watch, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Drop [LegacyImplementedInBaseClass] from AbstractWorker IDL interface Drop [LegacyImplementedInBaseClass] from AbstractWorker IDL interface. R=haraken BUG=344224 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167263

Patch Set 1 #

Patch Set 2 : Reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/workers/AbstractWorker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Inactive
6 years, 10 months ago (2014-02-16 19:16:45 UTC) #1
haraken
LGTM
6 years, 10 months ago (2014-02-16 23:17:48 UTC) #2
haraken
(the side-by-side diff is broken though.)
6 years, 10 months ago (2014-02-16 23:18:05 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-16 23:36:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168423003/100001
6 years, 10 months ago (2014-02-16 23:36:09 UTC) #5
Inactive
The CQ bit was unchecked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:29:48 UTC) #6
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 01:29:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168423003/100001
6 years, 10 months ago (2014-02-17 01:30:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-17 04:47:30 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=12688
6 years, 10 months ago (2014-02-17 04:47:31 UTC) #10
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-17 05:05:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/168423003/100001
6 years, 10 months ago (2014-02-17 05:05:32 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-17 05:05:46 UTC) #13
Message was sent while issue was closed. 
Change committed as 167263

Powered by Google App Engine
This is Rietveld 408576698