Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 168423002: Revert of Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. (Closed)

Created:
6 years, 10 months ago by xiyuan
Modified:
6 years, 10 months ago
Reviewers:
danakj, piman
CC:
chromium-reviews, jbauman+watch_chromium.org, nkostylev+watch_chromium.org, Ian Vollick, jam, sievers+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, danakj+watch_chromium.org, davemoore+watch_chromium.org, jamesr, piman, reveman
Visibility:
Public.

Description

Revert of Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. (https://codereview.chromium.org/164183012/) Reason for revert: Breaks compositor_unittests on ChromeOS. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/39630 LayerWithRealCompositorTest.Delegate (run #1): [ RUN ] LayerWithRealCompositorTest.Delegate ../../ui/compositor/layer_unittest.cc:527: Failure Value of: l1->bounds().size() Actual: 8-byte object \u003C90-01 00-00 90-01 00-00> Expected: delegate.paint_size() Which is: 8-byte object \u003C00-00 00-00 00-00 00-00> ... LayerWithRealCompositorTest.NoScaleCanvas (run #1): [ RUN ] LayerWithRealCompositorTest.NoScaleCanvas ../../ui/compositor/layer_unittest.cc:1311: Failure Value of: l1_delegate.paint_size().ToString() Actual: "0x0" Expected: "280x360" [ FAILED ] LayerWithRealCompositorTest.NoScaleCanvas (112 ms) ... I can repro the failures on my dev box and revert this CL fixes the problem. Original issue's description: > Remove --enable-per-tile-painting and --ui-enable-per-tile-painting. > > The ui flag is always true on ChromeOS and off elsewhere. The other is > never on and we're not planning to turn it on. > > R=piman > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251538 TBR=piman@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M cc/base/switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/base/switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
xiyuan
Created Revert of Remove --enable-per-tile-painting and --ui-enable-per-tile-painting.
6 years, 10 months ago (2014-02-15 07:08:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/168423002/1
6 years, 10 months ago (2014-02-15 07:08:47 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-15 07:09:21 UTC) #3
Message was sent while issue was closed.
Change committed as 251553

Powered by Google App Engine
This is Rietveld 408576698