Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684203002: Temporarily disable flaky tests, this should only be for today. (Closed)

Created:
4 years, 10 months ago by David Yen
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable flaky tests, this should only be for today. R=kbr@chromium.org BUG=584872 Committed: https://crrev.com/d1a4b660eb29113ef2a08f8544ebf1f2b212e6ec Cr-Commit-Position: refs/heads/master@{#374777}

Patch Set 1 #

Patch Set 2 : Removed decorators #

Total comments: 2

Patch Set 3 : Use expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M content/test/gpu/gpu_tests/context_lost_expectations.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
David Yen
4 years, 10 months ago (2016-02-10 18:49:34 UTC) #1
Ken Russell (switch to Gerrit)
https://codereview.chromium.org/1684203002/diff/20001/content/test/gpu/gpu_tests/context_lost.py File content/test/gpu/gpu_tests/context_lost.py (right): https://codereview.chromium.org/1684203002/diff/20001/content/test/gpu/gpu_tests/context_lost.py#newcode350 content/test/gpu/gpu_tests/context_lost.py:350: # ps, ps.base_dir, self.GetExpectations())) This isn't the right way ...
4 years, 10 months ago (2016-02-10 19:03:00 UTC) #2
David Yen
https://codereview.chromium.org/1684203002/diff/20001/content/test/gpu/gpu_tests/context_lost.py File content/test/gpu/gpu_tests/context_lost.py (right): https://codereview.chromium.org/1684203002/diff/20001/content/test/gpu/gpu_tests/context_lost.py#newcode350 content/test/gpu/gpu_tests/context_lost.py:350: # ps, ps.base_dir, self.GetExpectations())) On 2016/02/10 19:03:00, Ken Russell ...
4 years, 10 months ago (2016-02-10 19:10:09 UTC) #3
David Yen
+zmo
4 years, 10 months ago (2016-02-10 21:20:11 UTC) #6
Zhenyao Mo
lgtm since it's only for a short period of time
4 years, 10 months ago (2016-02-10 21:21:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684203002/40001
4 years, 10 months ago (2016-02-10 21:28:12 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-10 23:24:27 UTC) #11
Ken Russell (switch to Gerrit)
lgtm after the fact.
4 years, 10 months ago (2016-02-11 00:42:18 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:32:29 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/d1a4b660eb29113ef2a08f8544ebf1f2b212e6ec
Cr-Commit-Position: refs/heads/master@{#374777}

Powered by Google App Engine
This is Rietveld 408576698