Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1684193003: markDocumentDirty() before styleResolverChanged(). (Closed)

Created:
4 years, 10 months ago by rune
Modified:
4 years, 10 months ago
Reviewers:
hayato
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

markDocumentDirty() before styleResolverChanged(). markDocumentDirty() was called after the active stylesheet list was updated which left the tree-scope dirty after everything else was clean. Switched the order of the statements. R=hayato@chromium.org Committed: https://crrev.com/0b4e6571be9250188d71e8679c49185e1b791101 Cr-Commit-Position: refs/heads/master@{#375139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684193003/1
4 years, 10 months ago (2016-02-11 14:35:54 UTC) #2
rune
ptal
4 years, 10 months ago (2016-02-11 14:35:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-11 15:42:01 UTC) #5
hayato
lgtm
4 years, 10 months ago (2016-02-12 04:15:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684193003/1
4 years, 10 months ago (2016-02-12 06:33:29 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 06:41:17 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:42:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b4e6571be9250188d71e8679c49185e1b791101
Cr-Commit-Position: refs/heads/master@{#375139}

Powered by Google App Engine
This is Rietveld 408576698