Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: components/web_restrictions/browser/web_restrictions_client_unittest.cc

Issue 1684153002: Web restrictions component. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test compilation errors. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_restrictions/browser/web_restrictions_client_unittest.cc
diff --git a/components/web_restrictions/browser/web_restrictions_client_unittest.cc b/components/web_restrictions/browser/web_restrictions_client_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..64f121ef986e4262bccee6140f08060adc9ef22a
--- /dev/null
+++ b/components/web_restrictions/browser/web_restrictions_client_unittest.cc
@@ -0,0 +1,103 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/bind.h"
+#include "base/run_loop.h"
+#include "components/web_restrictions/browser/mock_web_restrictions_client.h"
+#include "components/web_restrictions/browser/web_restrictions_client.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using web_restrictions::WebRestrictionsClient;
+using web_restrictions::MockWebRestrictionsClient;
+
+namespace {
+
+bool g_returned_result;
+
+void ResultCallback(const base::Closure& quit_closure, bool result) {
+ g_returned_result = result;
+ quit_closure.Run();
+}
+
+} // namespace
+
+TEST(WebRestrictionsClientTest, ShouldProceed) {
+ // Mock the Java WebRestrictionsClient. The real version
+ // would need a content provider to do anything.
+ MockWebRestrictionsClient mock;
+ content::TestBrowserThreadBundle thread_bundle;
+ WebRestrictionsClient client;
Bernhard Bauer 2016/02/22 12:39:17 You could also put these into a test fixture.
aberent 2016/02/23 13:52:37 Done.
+ client.SetAuthority("Good");
+ // First call should go to Web Restrictions Content Provider, and return a
+ // delayed result.
+ g_returned_result = false;
+ base::RunLoop run_loop;
+ EXPECT_EQ(web_restrictions::PENDING,
+ client.ShouldProceed(
+ true, GURL("http://example.com"),
+ base::Bind(&ResultCallback, run_loop.QuitClosure())));
+ run_loop.Run();
+ EXPECT_TRUE(g_returned_result);
+ // A repeated call should go to the cache and return a result immediately.
+ EXPECT_EQ(web_restrictions::ALLOW,
+ client.ShouldProceed(
+ true, GURL("http://example.com"),
+ base::Bind(&ResultCallback, run_loop.QuitClosure())));
+ // However a different url should miss the cache
+ g_returned_result = false;
+ base::RunLoop run_loop2;
+ EXPECT_EQ(web_restrictions::PENDING,
+ client.ShouldProceed(
+ true, GURL("http://example.com/2"),
+ base::Bind(&ResultCallback, run_loop2.QuitClosure())));
+ run_loop2.Run();
+ EXPECT_TRUE(g_returned_result);
+ // Switching the authority should clear the cache.
+ client.SetAuthority("Good2");
+ g_returned_result = false;
+ base::RunLoop run_loop3;
+ EXPECT_EQ(web_restrictions::PENDING,
+ client.ShouldProceed(
+ true, GURL("http://example.com/2"),
+ base::Bind(&ResultCallback, run_loop3.QuitClosure())));
+ run_loop3.Run();
+ EXPECT_TRUE(g_returned_result);
+ // Try getting a bad result
+ client.SetAuthority("Bad");
+ g_returned_result = true;
+ base::RunLoop run_loop4;
+ EXPECT_EQ(web_restrictions::PENDING,
+ client.ShouldProceed(
+ true, GURL("http://example.com/2"),
+ base::Bind(&ResultCallback, run_loop4.QuitClosure())));
+ run_loop4.Run();
+ EXPECT_FALSE(g_returned_result);
+ std::string error_html;
+ EXPECT_TRUE(client.GetErrorHtml(GURL("http://example.com/2"), &error_html));
+ EXPECT_EQ("http://example.com/2", error_html);
+}
+
+TEST(WebRestrictionsClientTest, RequestPermission) {
+ // Mock the Java WebRestrictionsClient. The real version
+ // would need a content provider to do anything.
+ MockWebRestrictionsClient mock;
+ content::TestBrowserThreadBundle thread_bundle;
+ WebRestrictionsClient client;
+ client.SetAuthority("Good");
+ base::RunLoop run_loop;
+ g_returned_result = false;
+ client.RequestPermission(GURL("http://example.com"),
+ base::Bind(&ResultCallback, run_loop.QuitClosure()));
+ run_loop.Run();
+ EXPECT_TRUE(g_returned_result);
+ client.SetAuthority("Bad");
+ base::RunLoop run_loop2;
+ g_returned_result = true;
+ client.RequestPermission(
+ GURL("http://example.com"),
+ base::Bind(&ResultCallback, run_loop2.QuitClosure()));
+ run_loop2.Run();
+ EXPECT_FALSE(g_returned_result);
+}

Powered by Google App Engine
This is Rietveld 408576698