Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1684133003: PPC: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in … (Closed)

Created:
4 years, 10 months ago by MTBrandyberry
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Mark null and undefined as undetectable, and use it to handle abstract equality comparison in the generic compare ic Port 3ce9e808c5b9a6149ac987213854b5d59005f366 Original commit message: Marking as undetectable makes abstract equality of null, undefined, and other undetectable objects easier. Supporting it in the generic compare IC significantly speeds up dynamic comparison between those values and JSReceivers by not falling back to the runtime. R=verwaest@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/d4bdd7672615624367aab123325d295c41d464fc Cr-Commit-Position: refs/heads/master@{#33876}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -23 lines) Patch
M src/crankshaft/ppc/lithium-codegen-ppc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +27 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
MTBrandyberry
4 years, 10 months ago (2016-02-10 19:02:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684133003/20001
4 years, 10 months ago (2016-02-10 19:02:20 UTC) #3
michael_dawson
On 2016/02/10 19:02:20, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 10 months ago (2016-02-10 19:04:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-10 19:21:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684133003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684133003/20001
4 years, 10 months ago (2016-02-10 20:07:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 20:08:09 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:40:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d4bdd7672615624367aab123325d295c41d464fc
Cr-Commit-Position: refs/heads/master@{#33876}

Powered by Google App Engine
This is Rietveld 408576698