Chromium Code Reviews| Index: net/base/proxy_delegate.h |
| diff --git a/net/base/proxy_delegate.h b/net/base/proxy_delegate.h |
| index 8ff6a7e999c21da42ffef7b417714128206cd662..49bff388d320d34a5fb7000dfd75992502fb2b64 100644 |
| --- a/net/base/proxy_delegate.h |
| +++ b/net/base/proxy_delegate.h |
| @@ -22,24 +22,26 @@ class URLRequest; |
| // Delegate for setting up a connection. |
| class NET_EXPORT ProxyDelegate { |
| public: |
| ProxyDelegate() { |
| } |
| virtual ~ProxyDelegate() { |
| } |
| - // Called as the proxy is being resolved for |url|. Allows the delegate to |
| - // override the proxy resolution decision made by ProxyService. The delegate |
| - // may override the decision by modifying the ProxyInfo |result|. |
| + // Called as the proxy is being resolved for |url| for a |method| request. |
|
bengr
2016/02/26 23:43:33
You need to say somewhere (here, but maybe also ot
|
| + // Allows the delegate to override the proxy resolution decision made by |
| + // ProxyService. The delegate may override the decision by modifying the |
| + // ProxyInfo |result|. |
| virtual void OnResolveProxy(const GURL& url, |
| + const std::string& method, |
|
bengr
2016/02/26 23:43:33
#include <string>
|
| int load_flags, |
| const ProxyService& proxy_service, |
| ProxyInfo* result) = 0; |
| // Called when use of |bad_proxy| fails due to |net_error|. |net_error| is |
| // the network error encountered, if any, and OK if the fallback was |
| // for a reason other than a network error (e.g. the proxy service was |
| // explicitly directed to skip a proxy). |
| virtual void OnFallback(const ProxyServer& bad_proxy, |
| int net_error) = 0; |