Chromium Code Reviews| Index: net/proxy/proxy_service.h |
| diff --git a/net/proxy/proxy_service.h b/net/proxy/proxy_service.h |
| index 377cde35aabba47b4abfe772d690e06ac015ba82..46d7009db29c0abe6f1169cbed88870191fb82f3 100644 |
| --- a/net/proxy/proxy_service.h |
| +++ b/net/proxy/proxy_service.h |
| @@ -120,50 +120,53 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver, |
| // |
| // We use the three possible proxy access types in the following order, |
| // doing fallback if one doesn't work. See "pac_script_decider.h" |
| // for the specifics. |
| // 1. WPAD auto-detection |
| // 2. PAC URL |
| // 3. named proxy |
| // |
| // Profiling information for the request is saved to |net_log| if non-NULL. |
| int ResolveProxy(const GURL& url, |
| + const std::string& method, |
|
bengr
2016/02/21 21:36:40
Add a description of |method| to the comment.
RyanSturm
2016/02/26 22:16:18
Done.
|
| int load_flags, |
| ProxyInfo* results, |
| const CompletionCallback& callback, |
| PacRequest** pac_request, |
| ProxyDelegate* proxy_delegate, |
| const BoundNetLog& net_log); |
| // Returns true if the proxy information could be determined without spawning |
| // an asynchronous task. Otherwise, |result| is unmodified. |
| bool TryResolveProxySynchronously(const GURL& raw_url, |
| + const std::string& method, |
| int load_flags, |
| ProxyInfo* result, |
| ProxyDelegate* proxy_delegate, |
| const BoundNetLog& net_log); |
| // This method is called after a failure to connect or resolve a host name. |
| // It gives the proxy service an opportunity to reconsider the proxy to use. |
| // The |results| parameter contains the results returned by an earlier call |
| // to ResolveProxy. The |net_error| parameter contains the network error |
| // code associated with the failure. See "net/base/net_error_list.h" for a |
| // list of possible values. The semantics of this call are otherwise |
| // similar to ResolveProxy. |
| // |
| // NULL can be passed for |pac_request| if the caller will not need to |
| // cancel the request. |
| // |
| // Returns ERR_FAILED if there is not another proxy config to try. |
| // |
| // Profiling information for the request is saved to |net_log| if non-NULL. |
| int ReconsiderProxyAfterError(const GURL& url, |
| + const std::string& method, |
| int load_flags, |
| int net_error, |
| ProxyInfo* results, |
| const CompletionCallback& callback, |
| PacRequest** pac_request, |
| ProxyDelegate* proxy_delegate, |
| const BoundNetLog& net_log); |
| // Explicitly trigger proxy fallback for the given |results| by updating our |
| // list of bad proxies to include the first entry of |results|, and, |
| @@ -326,20 +329,21 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver, |
| // Completing synchronously means we don't need to query ProxyResolver. |
| int TryToCompleteSynchronously(const GURL& url, |
| int load_flags, |
| ProxyDelegate* proxy_delegate, |
| ProxyInfo* result); |
| // Identical to ResolveProxy, except that |callback| is permitted to be null. |
| // if |callback.is_null()|, this function becomes a thin wrapper around |
| // |TryToCompleteSynchronously|. |
| int ResolveProxyHelper(const GURL& url, |
| + const std::string& method, |
| int load_flags, |
| ProxyInfo* results, |
| const CompletionCallback& callback, |
| PacRequest** pac_request, |
| ProxyDelegate* proxy_delegate, |
| const BoundNetLog& net_log); |
| // Cancels all of the requests sent to the ProxyResolver. These will be |
| // restarted when calling SetReady(). |
| void SuspendAllPendingRequests(); |
| @@ -351,20 +355,21 @@ class NET_EXPORT ProxyService : public NetworkChangeNotifier::IPAddressObserver, |
| // Returns true if |pending_requests_| contains |req|. |
| bool ContainsPendingRequest(PacRequest* req); |
| // Removes |req| from the list of pending requests. |
| void RemovePendingRequest(PacRequest* req); |
| // Called when proxy resolution has completed (either synchronously or |
| // asynchronously). Handles logging the result, and cleaning out |
| // bad entries from the results list. |
| int DidFinishResolvingProxy(const GURL& url, |
| + const std::string& method, |
| int load_flags, |
| ProxyDelegate* proxy_delegate, |
| ProxyInfo* result, |
| int result_code, |
| const BoundNetLog& net_log, |
| base::TimeTicks start_time, |
| bool script_executed); |
| // Start initialization using |fetched_config_|. |
| void InitializeUsingLastFetchedConfig(); |