Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1684123002: Revert of Fix SELinux violation when opening Chrome on Android (Closed)

Created:
4 years, 10 months ago by hartmanng
Modified:
4 years, 10 months ago
CC:
simonb (inactive), chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix SELinux violation when opening Chrome on Android (patchset #4 id:60001 of https://codereview.chromium.org/1655983002/ ) Reason for revert: Given the M bot that this broke, plus http://crbug.com/585421, I'm reverting until I can properly sort out the bugs here. Original issue's description: > Fix SELinux violation when opening Chrome on Android > > This was caused by calling PathUtils.setPrivateDataDirectorySuffix() > on the renderer process. Moving that call into > ChromeBrowserInitializer should fix this. > > BUG=560152 > > Committed: https://crrev.com/b5ce1bf969e760539c96fd215756dd1716415f25 > Cr-Commit-Position: refs/heads/master@{#373820} TBR=yfriedman@chromium.org,simonb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=560152 Committed: https://crrev.com/cfe52d9360013f0078ad6aa7ae7317e6b524b72c Cr-Commit-Position: refs/heads/master@{#374666}

Patch Set 1 #

Messages

Total messages: 8 (1 generated)
hartmanng
Created Revert of Fix SELinux violation when opening Chrome on Android
4 years, 10 months ago (2016-02-10 15:04:18 UTC) #1
Yaron
lgtm
4 years, 10 months ago (2016-02-10 15:04:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684123002/1
4 years, 10 months ago (2016-02-10 15:05:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684123002/1
4 years, 10 months ago (2016-02-10 15:33:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684123002/1
4 years, 10 months ago (2016-02-10 16:03:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 16:11:26 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 16:12:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfe52d9360013f0078ad6aa7ae7317e6b524b72c
Cr-Commit-Position: refs/heads/master@{#374666}

Powered by Google App Engine
This is Rietveld 408576698