Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: src/interpreter/bytecodes.cc

Issue 1684113002: [Interpreter] Handle negative ints in generate-bytecode-expectations. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecodes.cc
diff --git a/src/interpreter/bytecodes.cc b/src/interpreter/bytecodes.cc
index 7d06f29317218bd8fc4112b37c6026c2f0603737..0e37e5e63ddb3b4b2d413d4dfdf8607beaf1127f 100644
--- a/src/interpreter/bytecodes.cc
+++ b/src/interpreter/bytecodes.cc
@@ -327,6 +327,17 @@ bool Bytecodes::IsRegisterOutputOperandType(OperandType operand_type) {
return false;
}
+// static
+bool Bytecodes::IsImmediateOperandType(OperandType operand_type) {
+ return operand_type == OperandType::kImm8;
+}
+
+// static
+bool Bytecodes::IsIndexOperandType(OperandType operand_type) {
+ return operand_type == OperandType::kIdx8 ||
+ operand_type == OperandType::kIdx16;
+}
rmcilroy 2016/02/10 15:26:12 nit - move above IsMaybeRegisterOperandType (and m
Stefano Sanfilippo 2016/02/10 15:52:00 Done.
+
namespace {
static Register DecodeRegister(const uint8_t* operand_start,
OperandType operand_type) {

Powered by Google App Engine
This is Rietveld 408576698