[Interpreter] Handle negative ints in generate-bytecode-expectations.

src/interpreter/bytecodes.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecodes.h"
 
 #include "src/frames.h"
 #include "src/interpreter/bytecode-traits.h"
 
 namespace v8 {
@@ skipping 246 matching lines @@
   return IsJumpImmediate(bytecode) || IsJumpConstant(bytecode) ||
          IsJumpConstantWide(bytecode);
 }
 
 
 // static
 bool Bytecodes::IsJumpOrReturn(Bytecode bytecode) {
   return bytecode == Bytecode::kReturn || IsJump(bytecode);
 }
 
-bool Bytecodes::IsMaybeRegisterOperandType(OperandType operand_type) {
-  return (operand_type == OperandType::kMaybeReg8 ||
-          operand_type == OperandType::kMaybeReg16);
+// static
+bool Bytecodes::IsIndexOperandType(OperandType operand_type) {
+  return operand_type == OperandType::kIdx8 ||
+         operand_type == OperandType::kIdx16;
 }
 
+// static
 bool Bytecodes::IsRegisterCountOperandType(OperandType operand_type) {
   return (operand_type == OperandType::kRegCount8 ||
           operand_type == OperandType::kRegCount16);
 }
 
 // static
+bool Bytecodes::IsMaybeRegisterOperandType(OperandType operand_type) {
+  return (operand_type == OperandType::kMaybeReg8 ||
+          operand_type == OperandType::kMaybeReg16);
+}
+
+// static
 bool Bytecodes::IsRegisterOperandType(OperandType operand_type) {
   switch (operand_type) {
 #define CASE(Name, _)        \
   case OperandType::k##Name: \
     return true;
     REGISTER_OPERAND_TYPE_LIST(CASE)
 #undef CASE
 #define CASE(Name, _)        \
   case OperandType::k##Name: \
     break;
@@ skipping 32 matching lines @@
 #define CASE(Name, _)        \
   case OperandType::k##Name: \
     break;
     NON_REGISTER_OPERAND_TYPE_LIST(CASE)
     REGISTER_INPUT_OPERAND_TYPE_LIST(CASE)
 #undef CASE
   }
   return false;
 }
 
+// static
+bool Bytecodes::IsImmediateOperandType(OperandType operand_type) {

[rmcilroy, 2016/02/10 16:43:14]

nit - move above IsRegisterCountOperandType

[Stefano Sanfilippo, 2016/02/10 16:49:30]

Done.

+  return operand_type == OperandType::kImm8;
+}
+
 namespace {
 static Register DecodeRegister(const uint8_t* operand_start,
                                OperandType operand_type) {
   switch (Bytecodes::SizeOfOperand(operand_type)) {
     case OperandSize::kByte:
       return Register::FromOperand(*operand_start);
     case OperandSize::kShort:
       return Register::FromWideOperand(ReadUnalignedUInt16(operand_start));
     case OperandSize::kNone: {
       UNREACHABLE();
@@ skipping 239 matching lines @@
   } else {
     std::ostringstream s;
     s << "r" << index();
     return s.str();
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8