Issue 16841006: Revert 205481 "Virtual context MakeCurrent tweaks."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16841006: Revert 205481 "Virtual context MakeCurrent tweaks." (Closed)

Created:
7 years, 6 months ago by no sievers

Modified:
7 years, 6 months ago

Reviewers:
no sievers

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 205481 "Virtual context MakeCurrent tweaks." > Virtual context MakeCurrent tweaks. > > Do not allow GLContextVirtual::MakeCurrent() without a decoder (state > restorer), since this only leads to state bugs. > > For this reason remove the necessity of having a current context during surface destruction (it's ugly anyway, since GLSurface is RefCounted). > > BUG=248395 > > Review URL: https://chromiumcodereview.appspot.com/15925007 TBR=sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205970

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -26 lines)			Patch
M	trunk/src/content/common/gpu/gpu_command_buffer_stub.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	trunk/src/content/common/gpu/image_transport_surface_mac.cc	View	6 chunks	+4 lines, -21 lines	0 comments	Download
M	trunk/src/gpu/command_buffer/service/gl_context_virtual.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

no sievers

7 years, 6 months ago (2013-06-12 23:42:42 UTC) #3

Message was sent while issue was closed.

On 2013/06/12 23:42:17, Daniel Sievers wrote:
> Committed patchset #1 manually as r205970.

I'll try to reland after https://codereview.chromium.org/16838007/ lands.

Expand Messages | Collapse Messages