Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1684093002: Tweak type info threshold. (Closed)

Created:
4 years, 10 months ago by Jakob Kummerow
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Tweak type info threshold. Let the world know (if it cares) that this is the kind of silliness that JS engines have to partake in if they want to look good on Sunspider (this should give 5% overall). Committed: https://crrev.com/4f62af4234e8ad74abd8e4cd3e492f7727efc768 Cr-Commit-Position: refs/heads/master@{#33866}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
4 years, 10 months ago (2016-02-10 12:59:57 UTC) #2
Yang
On 2016/02/10 12:59:57, Jakob wrote: lgtm.
4 years, 10 months ago (2016-02-10 13:08:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684093002/1
4 years, 10 months ago (2016-02-10 13:13:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 13:40:58 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4f62af4234e8ad74abd8e4cd3e492f7727efc768 Cr-Commit-Position: refs/heads/master@{#33866}
4 years, 10 months ago (2016-02-10 13:41:26 UTC) #8
Jakob Kummerow
4 years, 10 months ago (2016-02-16 10:34:57 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1699063002/ by jkummerow@chromium.org.

The reason for reverting is: Tanks Mandreel-latency..

Powered by Google App Engine
This is Rietveld 408576698