Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 1684073006: Reland of [turbofan] ARM: Improve AND instruction selection (Closed)

Created:
4 years, 10 months ago by martyn.capewell
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of [turbofan] ARM: Improve AND instruction selection Improve instruction selector for mask and shift operations by using cheaper instructions where possible, in preference to UBFX. Reverted because it was suspected of causing a couple of flaky tests to fail, but investigation suggests this is unlikely. Original review: https://codereview.chromium.org/1677023002 BUG= Committed: https://crrev.com/357e0143293a29661bb590b3cee517e5fc6c40ec Cr-Commit-Position: refs/heads/master@{#33988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -32 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +50 lines, -26 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 7 chunks +70 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
martyn.capewell
4 years, 10 months ago (2016-02-12 16:04:59 UTC) #3
Benedikt Meurer
Still LGTM. :-)
4 years, 10 months ago (2016-02-12 17:38:20 UTC) #4
Michael Achenbach
lgtm
4 years, 10 months ago (2016-02-12 19:12:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684073006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684073006/1
4 years, 10 months ago (2016-02-15 10:41:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 11:09:56 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 11:10:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/357e0143293a29661bb590b3cee517e5fc6c40ec
Cr-Commit-Position: refs/heads/master@{#33988}

Powered by Google App Engine
This is Rietveld 408576698