components/arc/arc_bridge_bootstrap.h - Issue 1684063002: Add ArcEnabled policy implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/arc/arc_bridge_bootstrap.h

Issue 1684063002: Add ArcEnabled policy implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26869593

Patch Set: Added browser test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/arc/arc_bridge_bootstrap.h

diff --git a/components/arc/arc_bridge_bootstrap.h b/components/arc/arc_bridge_bootstrap.h

index a86c97420af27a55cbd9e46d6921dfcd334a42f8..e08a5e1344bdcfa0482a44d9c1a57fb5a2e4c1a1 100644

--- a/components/arc/arc_bridge_bootstrap.h

+++ b/components/arc/arc_bridge_bootstrap.h

@@ -40,6 +40,9 @@ class ArcBridgeBootstrap {

// Stops the currently-running instance.

virtual void Stop() = 0;

+ // Set instance for testing. ArcBridgeBootstrap owns |bootstrap|

+ // until Create() is called, passes ownership to a caller.

bartfab (slow) 2016/03/02 14:45:40 Nit 1: s/passes/then passes/ Nit 2: s/ a / the /

Polina Bondarenko 2016/03/06 20:22:33 Done.

+ static void SetBootstrapForTesting(ArcBridgeBootstrap* bootstrap);

bartfab (slow) 2016/03/02 14:45:40 Use a scoped_ptr to indicate ownership transfer.

Polina Bondarenko 2016/03/06 20:22:33 Done.

protected:

ArcBridgeBootstrap();