Add ArcEnabled policy implementation

components/arc/arc_service_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_service_manager.h"
 
 #include "base/sequenced_task_runner.h"
 #include "base/thread_task_runner_handle.h"
 #include "components/arc/arc_bridge_bootstrap.h"
 #include "components/arc/arc_bridge_service_impl.h"
 #include "components/arc/clipboard/arc_clipboard_bridge.h"
 #include "components/arc/ime/arc_ime_bridge.h"
 #include "components/arc/input/arc_input_bridge.h"
 #include "components/arc/net/arc_net_host_impl.h"
 #include "components/arc/power/arc_power_bridge.h"
 #include "ui/arc/notification/arc_notification_manager.h"
 
 namespace arc {
 
 namespace {
 
 // Weak pointer.  This class is owned by ChromeBrowserMainPartsChromeos.
 ArcServiceManager* g_arc_service_manager = nullptr;
 
+// This pointer is owned by ArcServiceManager.
+ArcBridgeService* g_arc_bridge_service_for_testing = nullptr;

[hidehiko, 2016/03/16 16:45:35]

Could you avoid the global var here?
Would it be possible to inject the ArcBridgeService instance via ctor's
argument?

ArcServiceManager::ArcServiceManager() : ArcServiceManager(nullptr) {
}

ArcServiceManager::ArcServiceManager(scoped_ptr<ArcBridgeService>
arc_bridge_service) {
  if (!arc_bridge_service) {
    arc_bridge_service.reset(new ArcBridgeServiceImpl(...));
  }
  arc_bridge_service_ = arc_bridge_service.Pass();

  :
}

[Polina Bondarenko, 2016/03/17 13:40:28]

Fixed:
1) Create ArcServiceManager(fake arc_bridge_service) in browser_test to pass
arc_bridge_service to real ArcServiceManager (owned by ArcPolicyTest).
2) Create ArcServiceManager in ArcServiceLauncher::Initialize(), which takes
passed from browser test arc_bridge_service and sets itself as
g_arc_service_manager.
3) There is correct ArcServiceManager and stuff with faked ArcBridgeService.
4) Run browser test ArcPolicyTest.
5) Destroy ArcServiceManager which is owned by ArcPolicyTest.
6) Destroy real ArcServiceManager (= g_arc_service_manager).

The most weird thing is that there are 2 ArcServiceManagers but it has to be
one. One of them is used just to pass arc_bridge_service. That's why DCHECKs for
checking uniqueness of ArcServiceManager are removed. But all instances of
ArcServiceManager are properly owned and destroyed.
I'm not sure which approach is better. New one may be seems to be clearer.

+
 }  // namespace
 
-ArcServiceManager::ArcServiceManager()
-    : arc_bridge_service_(
-          new ArcBridgeServiceImpl(ArcBridgeBootstrap::Create())) {
+ArcServiceManager::ArcServiceManager() {
   DCHECK(!g_arc_service_manager);
   g_arc_service_manager = this;
 
+  if (g_arc_bridge_service_for_testing) {
+    arc_bridge_service_.reset(g_arc_bridge_service_for_testing);
+    g_arc_bridge_service_for_testing = nullptr;
+  } else {
+    arc_bridge_service_.reset(new ArcBridgeServiceImpl(
+        ArcBridgeBootstrap::Create()));
+  }
+
   AddService(make_scoped_ptr(new ArcClipboardBridge(arc_bridge_service())));
   AddService(make_scoped_ptr(new ArcImeBridge(arc_bridge_service())));
   AddService(make_scoped_ptr(new ArcInputBridge(arc_bridge_service())));
   AddService(make_scoped_ptr(new ArcNetHostImpl(arc_bridge_service())));
   AddService(make_scoped_ptr(new ArcPowerBridge(arc_bridge_service())));
 }
 
 ArcServiceManager::~ArcServiceManager() {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(g_arc_service_manager == this);
   g_arc_service_manager = nullptr;
+  if (g_arc_bridge_service_for_testing) {
+    delete g_arc_bridge_service_for_testing;
+  }
 }
 
 // static
 ArcServiceManager* ArcServiceManager::Get() {
   DCHECK(g_arc_service_manager);
   DCHECK(g_arc_service_manager->thread_checker_.CalledOnValidThread());
   return g_arc_service_manager;
 }
 
 ArcBridgeService* ArcServiceManager::arc_bridge_service() {
   DCHECK(thread_checker_.CalledOnValidThread());
   return arc_bridge_service_.get();
 }
 
 void ArcServiceManager::AddService(scoped_ptr<ArcService> service) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   services_.emplace_back(std::move(service));
 }
 
 void ArcServiceManager::OnPrimaryUserProfilePrepared(
     const AccountId& account_id) {
   DCHECK(thread_checker_.CalledOnValidThread());
 
   AddService(make_scoped_ptr(
       new ArcNotificationManager(arc_bridge_service(), account_id)));
 }
 
+//static
+void ArcServiceManager::SetArcBridgeServiceForTesting(
+    scoped_ptr<ArcBridgeService> arc_bridge_service) {
+  if (g_arc_bridge_service_for_testing) {
+    delete g_arc_bridge_service_for_testing;
+  }
+  g_arc_bridge_service_for_testing = arc_bridge_service.release();
+}
+
 }  // namespace arc