Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: components/arc/test/fake_arc_bridge_bootstrap.h

Issue 1684063002: Add ArcEnabled policy implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@26869593
Patch Set: Added browser test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_
6 #define COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_
7
8 #include "components/arc/arc_bridge_bootstrap.h"
9
10 namespace arc {
11
12 class FakeArcBridgeInstance;
13
14 // A fake ArcBridgeBootstrap that creates a local connection.
15 class FakeArcBridgeBootstrap : public ArcBridgeBootstrap {
16 public:
17 explicit FakeArcBridgeBootstrap(FakeArcBridgeInstance* instance);
18 ~FakeArcBridgeBootstrap() override {}
bartfab (slow) 2016/03/02 14:45:41 Nit: Do we really need to override this?
Polina Bondarenko 2016/03/06 20:22:34 Yes, g_bootstrap_for_testing is deleted in destruc
bartfab (slow) 2016/03/07 13:44:04 I do not understand. Yes, ArcBridgeBootstrap::~Arc
19
20 void Start() override;
bartfab (slow) 2016/03/02 14:45:41 Nit: // ArcBridgeBootstrap:
Polina Bondarenko 2016/03/06 20:22:34 Done.
21 void Stop() override;
22
23 private:
24 // Owned by the caller.
25 FakeArcBridgeInstance* instance_;
26 DISALLOW_COPY_AND_ASSIGN(FakeArcBridgeBootstrap);
bartfab (slow) 2016/03/02 14:45:41 Nit 1: Add blank line above. Nit 2: #include "base
Polina Bondarenko 2016/03/06 20:22:34 Done.
27 };
28
29 } // namespace arc
30
31 #endif // COMPONENTS_ARC_TEST_FAKE_ARC_BRIDGE_BOOTSTRAP_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698