Add ArcEnabled policy implementation

components/arc/arc_bridge_bootstrap.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/arc/arc_bridge_bootstrap.h"
 
 #include <fcntl.h>
 #include <grp.h>
 #include <unistd.h>
 
@@ skipping 16 matching lines @@
 #include "mojo/edk/embedder/platform_channel_pair.h"
 #include "mojo/edk/embedder/platform_channel_utils_posix.h"
 #include "mojo/edk/embedder/platform_handle_vector.h"
 #include "mojo/edk/embedder/scoped_platform_handle.h"
 #include "mojo/public/cpp/bindings/binding.h"
 
 namespace arc {
 
 namespace {
 
+scoped_ptr<ArcBridgeBootstrap> fake_bootstrap_;

[bartfab (slow), 2016/03/02 14:45:40]

1) Nit: It may not be a fake - it could be a mock. A name like
"bootstrap_for_testing" would be more general.
2) Nit: Globals are prefixed with "g_"
3) Nit: Remove the "_" suffix. This is not a member.
4) This is probably introducing a static initializer, which is not allowed in
Chrome code.

[Polina Bondarenko, 2016/03/06 20:22:33]

Done, fixed to pointer.

+
 // We do not know the PID of ARC, since Chrome does not create it directly.
 // Since Mojo in POSIX does not use the child PID except as an unique
 // identifier for the routing table, rather than doing a lot of plumbing in the
 // whole system to get the correct PID, just use an arbitrary number that will
 // never be used by a legitimate process. Chrome OS assigns unassigned PIDs
 // sequentially until it reaches a certain maximum value (Chrome OS uses the
 // default value of 32k), at which point it loops around to zero. An arbitrary
 // number larger than the maximum should be safe.
 const pid_t kArcPid = 0x3DE0EA7C;
 
@@ skipping 287 matching lines @@
 void ArcBridgeBootstrapImpl::SetState(State state) {
   DCHECK(thread_checker_.CalledOnValidThread());
   // DCHECK on enum classes not supported.
   DCHECK(state_ != state);
   state_ = state;
 }
 
 }  // namespace
 
 ArcBridgeBootstrap::ArcBridgeBootstrap() {}
-ArcBridgeBootstrap::~ArcBridgeBootstrap() {}
+ArcBridgeBootstrap::~ArcBridgeBootstrap() {

[bartfab (slow), 2016/03/02 14:45:40]

Nit: Add a blank line above.

[Polina Bondarenko, 2016/03/06 20:22:33]

Done.

+  fake_bootstrap_.reset();

[bartfab (slow), 2016/03/02 14:45:40]

This should not be necessary. The global fake_bootstrap_ will eventually be
destroyed, reaping any ArcBridgeBootstrap it may be holding.

+}
 
 // static
 scoped_ptr<ArcBridgeBootstrap> ArcBridgeBootstrap::Create() {
-  return make_scoped_ptr(new ArcBridgeBootstrapImpl());
+  if (fake_bootstrap_ != NULL) {

[bartfab (slow), 2016/03/02 14:45:40]

Nit: s/NULL/nullptr/ or, even easier, "if (fake_bootstrap_) {"

[Polina Bondarenko, 2016/03/06 20:22:33]

Done.

+    return make_scoped_ptr(fake_bootstrap_.release());
+  } else {
+    return make_scoped_ptr(new ArcBridgeBootstrapImpl());
+  }
+}
+
+// static
+void ArcBridgeBootstrap::SetBootstrapForTesting(ArcBridgeBootstrap* bootstrap) {
+  fake_bootstrap_.reset(bootstrap);
 }
 
 }  // namespace arc