Fix build failure of chrome_public_apk on Android GN build

Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not available on Android, and their invocation cause a link error on Android GN build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.

Committed: https://crrev.com/a2f1ff976845da38f13efaec18aead3f04142ac7
Cr-Commit-Position: refs/heads/master@{#374764}

[tzik, 2016-02-10 09:37:13]

Description was changed from

==========
Fix build failure of chrome_public_apk on Android GN build

BUG=
==========

to

==========
Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not
available on Android, and their invocation cause a link error on Android GN
build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.
==========

[tzik, 2016-02-10 09:37:13]

tzik@chromium.org changed reviewers:
+ dfalcantara@chromium.org, reillyg@chromium.org, thestig@chromium.org

[tzik, 2016-02-10 09:37:31]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-10 09:37:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684043002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684043002/1

[tzik, 2016-02-10 10:36:52]

PTAL

[commit-bot: I haz the power, 2016-02-10 11:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-10 11:23:49]

Dry run: This issue passed the CQ dry run.

[gone, 2016-02-10 17:56:00]

lgtm

[Reilly Grant (use Gerrit), 2016-02-10 19:13:29]

lgtm

[Lei Zhang, 2016-02-10 20:14:11]

lgtm

I had plans to do some refactoring in application_lifetime.cc, but haven't had
time. This is fine in the meanwhile.

https://codereview.chromium.org/1684043002/diff/1/chrome/browser/lifetime/app...
File chrome/browser/lifetime/application_lifetime.cc (right):

https://codereview.chromium.org/1684043002/diff/1/chrome/browser/lifetime/app...
chrome/browser/lifetime/application_lifetime.cc:314: #endif
It would be nice to add // !defined(OS_ANDROID) because it's rather far from the
#if.

[tzik, 2016-02-10 21:12:14]

https://codereview.chromium.org/1684043002/diff/1/chrome/browser/lifetime/app...
File chrome/browser/lifetime/application_lifetime.cc (right):

https://codereview.chromium.org/1684043002/diff/1/chrome/browser/lifetime/app...
chrome/browser/lifetime/application_lifetime.cc:314: #endif
On 2016/02/10 20:14:10, Lei Zhang wrote:
> It would be nice to add // !defined(OS_ANDROID) because it's rather far from
the
> #if.

Done. (here and elsewhere)

[tzik, 2016-02-10 21:12:20]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-02-10 21:12:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, reillyg@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/1684043002/#ps20001
(title: "+#endif comment")

[commit-bot: I haz the power, 2016-02-10 21:14:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1684043002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1684043002/20001

[commit-bot: I haz the power, 2016-02-10 23:00:00]

Description was changed from

==========
Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not
available on Android, and their invocation cause a link error on Android GN
build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.
==========

to

==========
Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not
available on Android, and their invocation cause a link error on Android GN
build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.
==========

[commit-bot: I haz the power, 2016-02-10 23:00:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-16 22:32:05]

Description was changed from

==========
Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not
available on Android, and their invocation cause a link error on Android GN
build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.
==========

to

==========
Fix build failure of chrome_public_apk on Android GN build

chrome::GetTotalBrowserCount() and ChromeWebUsbPermissionBubble::Bind are not
available on Android, and their invocation cause a link error on Android GN
build.
The caller is also not used on Android, and seems to be GCed on GYP build.

This CL ifdefs out the problematic code to fix it.

Committed: https://crrev.com/a2f1ff976845da38f13efaec18aead3f04142ac7
Cr-Commit-Position: refs/heads/master@{#374764}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:05]

Patchset 2 (id:??) landed as
https://crrev.com/a2f1ff976845da38f13efaec18aead3f04142ac7
Cr-Commit-Position: refs/heads/master@{#374764}