Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1684023003: Add tests for UserGestureIndicator class. (Closed)

Created:
4 years, 10 months ago by Andrey Kraynov
Modified:
4 years, 10 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add tests for UserGestureIndicator class. BUG= TEST=blink_platform_unittests --gtest_filter="UserGestureIndicatorTest*" Committed: https://crrev.com/a6b2a874dfd6639a75018e349f6b4de0fcb72924 Cr-Commit-Position: refs/heads/master@{#374639}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change header comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -0 lines) Patch
A third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp View 1 1 chunk +102 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Andrey Kraynov
Hi! Recently I've looked at the UserGestureIndicator code and I want to improve it a ...
4 years, 10 months ago (2016-02-10 10:03:01 UTC) #2
tkent
https://codereview.chromium.org/1684023003/diff/1/third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp File third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp (right): https://codereview.chromium.org/1684023003/diff/1/third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp#newcode1 third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp:1: /* Please use the 3-line header like platform/JSONParserTest.cpp
4 years, 10 months ago (2016-02-10 10:08:53 UTC) #3
Andrey Kraynov
https://codereview.chromium.org/1684023003/diff/1/third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp File third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp (right): https://codereview.chromium.org/1684023003/diff/1/third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp#newcode1 third_party/WebKit/Source/platform/UserGestureIndicatorTest.cpp:1: /* On 2016/02/10 10:08:53, tkent wrote: > Please use ...
4 years, 10 months ago (2016-02-10 10:20:36 UTC) #4
tkent
lgtm
4 years, 10 months ago (2016-02-10 10:21:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1684023003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1684023003/20001
4 years, 10 months ago (2016-02-10 10:22:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-10 11:22:42 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 11:24:09 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a6b2a874dfd6639a75018e349f6b4de0fcb72924
Cr-Commit-Position: refs/heads/master@{#374639}

Powered by Google App Engine
This is Rietveld 408576698