Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Issue 1683983003: [heap] Improve IncrementalMarking::UpdateMarkingDequeAfterScavenge. (Closed)

Created:
4 years, 10 months ago by Hannes Payer (out of office)
Modified:
4 years, 10 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Improve IncrementalMarking::UpdateMarkingDequeAfterScavenge. Black allocation during scavenges will push objects on the marking deque that point to to-space. They should not be cleared. BUG=chromium:561449 LOG=n Committed: https://crrev.com/0ecdd93282a0ff9a2bb4ff8d2a3401fe1368124d Cr-Commit-Position: refs/heads/master@{#33875}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/heap/incremental-marking.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Hannes Payer (out of office)
4 years, 10 months ago (2016-02-10 19:22:26 UTC) #3
ulan
lgtm
4 years, 10 months ago (2016-02-10 19:32:31 UTC) #4
Michael Lippautz
LGTM, nice find ;)
4 years, 10 months ago (2016-02-10 19:44:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683983003/1
4 years, 10 months ago (2016-02-10 20:00:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 20:01:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-11 10:40:56 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ecdd93282a0ff9a2bb4ff8d2a3401fe1368124d
Cr-Commit-Position: refs/heads/master@{#33875}

Powered by Google App Engine
This is Rietveld 408576698