Enable threadsafe static initialization (aka 'magic statics')

Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.

Equivalent change in the Flutter engine is here: https://github.com/flutter/engine/pull/2375

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a406dee71d184264bee3ac7d8765deff733c5826

[jamesr, 2016-02-10 02:11:26]

Description was changed from

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 gaurantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.
==========

to

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.
==========

[jamesr, 2016-02-10 02:12:08]

Description was changed from

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.
==========

to

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.

Equivalent change in the Flutter engine is here:
https://github.com/flutter/engine/pull/2375
==========

[jamesr, 2016-02-10 02:12:13]

jamesr@chromium.org changed reviewers:
+ viettrungluu@chromium.org

[viettrungluu, 2016-02-10 15:49:47]

lgtm

[jamesr, 2016-02-10 17:54:12]

Description was changed from

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.

Equivalent change in the Flutter engine is here:
https://github.com/flutter/engine/pull/2375
==========

to

==========
Enable threadsafe static initialization (aka 'magic statics')

C++11 guarantees that initialization of function statics will be
threadsafe. We disabled this by passing -fno-threadsafe-statics because
we used to support building using visual studio and older versions
(older than 2015) did not implement this functionality. Now we only use
modern toolchains which do support this and it's increasingly likely
that libraries we want to use and that other C++ developers will
expect rely on the standard behavior instead of our nonstandard init.
Using the toolchain's implementation of threadsafe initialization is
also very likely to be more efficient than our own handrolled
threadsafe initialization and less error prone.

With the specified behavior, many uses of base::Singleton for threadsafe
initialization can be replaced by function statics for a performance
boost. There's also a very slight risk that code that was depending on
racy initialization could break, but such code is at the very least
suspect if not outright broken already.

Equivalent change in the Flutter engine is here:
https://github.com/flutter/engine/pull/2375

R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/a406dee71d184264bee3ac7d876...
==========

[jamesr, 2016-02-10 17:54:14]

Committed patchset #1 (id:1) manually as
a406dee71d184264bee3ac7d8765deff733c5826 (presubmit successful).