Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1683953002: Remove unused DataReductionProxy code (Closed)

Created:
4 years, 10 months ago by tbansal1
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused DataReductionProxy code. All this code hinges on field trial "DataReductionProxyConfigFetchBytes" defined in d_r_p_config_retrieval_params.cc. This experiment has never been turned on. BUG=573087 Committed: https://crrev.com/0cfe418c2a8d7bc1f3445e9840b47a6c5a16d3fa Cr-Commit-Position: refs/heads/master@{#374706}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1037 lines) Patch
M chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_io_data.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_retrieval_params.h View 1 chunk +0 lines, -155 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_retrieval_params.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_config_retrieval_params_unittest.cc View 1 chunk +0 lines, -230 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_experiments_stats.h View 1 chunk +0 lines, -81 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_experiments_stats.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D components/data_reduction_proxy/core/browser/data_reduction_proxy_experiments_stats_unittest.cc View 1 chunk +0 lines, -165 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.h View 3 chunks +0 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 4 chunks +2 lines, -9 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h View 3 chunks +4 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.cc View 4 chunks +1 line, -8 lines 0 comments Download
M ios/chrome/browser/data_reduction_proxy/ios_chrome_data_reduction_proxy_io_data.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
tbansal1
sclittle: ptal. thanks.
4 years, 10 months ago (2016-02-10 02:01:05 UTC) #5
sclittle
LGTM! Thanks for removing all this dead code.
4 years, 10 months ago (2016-02-10 18:46:14 UTC) #6
tbansal1
asvitkine: ptal at histograms.xml. thanks.
4 years, 10 months ago (2016-02-10 19:01:57 UTC) #8
Alexei Svitkine (slow)
lgtm
4 years, 10 months ago (2016-02-10 19:05:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683953002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683953002/20001
4 years, 10 months ago (2016-02-10 19:08:17 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-10 19:57:32 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:30:36 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cfe418c2a8d7bc1f3445e9840b47a6c5a16d3fa
Cr-Commit-Position: refs/heads/master@{#374706}

Powered by Google App Engine
This is Rietveld 408576698