Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 1683913003: Round color values in AlphaBlend() as we already do in HSLShift(). (Closed)

Created:
4 years, 10 months ago by Peter Kasting
Modified:
4 years, 10 months ago
Reviewers:
msw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Round color values in AlphaBlend() as we already do in HSLShift(). BUG=none TEST=none Committed: https://crrev.com/55d7eb84173f77fc55bd879d4f200378cc5c9bec Cr-Commit-Position: refs/heads/master@{#374808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M ui/gfx/color_utils.cc View 3 chunks +9 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Kasting
Mike, I know this isn't technically your area of expertise, but as you're in ui/gfx/OWNERS, ...
4 years, 10 months ago (2016-02-10 02:47:24 UTC) #2
msw
sure, lgtm
4 years, 10 months ago (2016-02-10 16:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683913003/1
4 years, 10 months ago (2016-02-11 00:41:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-11 00:52:27 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:33:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55d7eb84173f77fc55bd879d4f200378cc5c9bec
Cr-Commit-Position: refs/heads/master@{#374808}

Powered by Google App Engine
This is Rietveld 408576698