Only assume the Win 10 frame is white when using the native frame.

Only assume the Win 10 frame is white when using the native frame.

Custom frames on Win 10 are just like custom frames on <10.

BUG=none
TEST=none

Committed: https://crrev.com/9a7425b13bb4f60c3ed1de6e6b68417fe7d482e9
Cr-Commit-Position: refs/heads/master@{#374783}

[Peter Kasting, 2016-02-10 04:56:44]

pkasting@chromium.org changed reviewers:
+ estade@chromium.org

[Evan Stade, 2016-02-10 22:45:37]

lgtm

out of curiosity, when do we use native vs non native frames on windows? is it
custom themes vs classic theme?

https://codereview.chromium.org/1683873003/diff/1/chrome/browser/ui/views/fra...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://codereview.chromium.org/1683873003/diff/1/chrome/browser/ui/views/fra...
chrome/browser/ui/views/frame/browser_view.cc:687: if (GetWidget() &&
GetWidget()->ShouldUseNativeFrame() &&
nit: i prefer curlies in this case (multi-line conditional)

[Peter Kasting, 2016-02-10 23:26:52]

On 2016/02/10 22:45:37, Evan Stade wrote:
> lgtm
> 
> out of curiosity, when do we use native vs non native frames on windows? is it
> custom themes vs classic theme?

We use the glass frame for non-custom themes rendered by the DWM ("glass" themes
on Vista-7, all native themes on 8+).

[Peter Kasting, 2016-02-10 23:27:07]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-02-10 23:28:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683873003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683873003/1

[commit-bot: I haz the power, 2016-02-10 23:39:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-16 22:32:38]

Description was changed from

==========
Only assume the Win 10 frame is white when using the native frame.

Custom frames on Win 10 are just like custom frames on <10.

BUG=none
TEST=none
==========

to

==========
Only assume the Win 10 frame is white when using the native frame.

Custom frames on Win 10 are just like custom frames on <10.

BUG=none
TEST=none

Committed: https://crrev.com/9a7425b13bb4f60c3ed1de6e6b68417fe7d482e9
Cr-Commit-Position: refs/heads/master@{#374783}
==========

[commit-bot: I haz the power, 2016-02-16 22:32:38]

Patchset 1 (id:??) landed as
https://crrev.com/9a7425b13bb4f60c3ed1de6e6b68417fe7d482e9
Cr-Commit-Position: refs/heads/master@{#374783}