Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
Committed: https://crrev.com/eb03d056f6f1535b78a9efce05898c4398d9d51c
Cr-Commit-Position: refs/heads/master@{#374559}

[yzshen1, 2016-02-09 21:23:17]

yzshen@chromium.org changed reviewers:
+ sky@chromium.org

[yzshen1, 2016-02-09 21:23:17]

Hi, Scott.

Would you please take a look? Thanks!

[sky, 2016-02-09 21:52:17]

LGTM

[yzshen1, 2016-02-09 23:39:21]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2016-02-09 23:39:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1683863002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-02-09 23:42:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683863002/40001

[commit-bot: I haz the power, 2016-02-09 23:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:53:56]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yzshen1, 2016-02-09 23:55:45]

Description was changed from

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
==========

to

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
==========

[yzshen1, 2016-02-09 23:55:45]

yzshen@chromium.org changed reviewers:
+ erg@chromium.org

[yzshen1, 2016-02-09 23:56:18]

On 2016/02/09 23:53:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Hi, Elliot.

Would you please do an OWNER review for clipboard_standalone_impl.cc? Thanks!

[Elliot Glaysher, 2016-02-09 23:56:45]

lgtm

[yzshen1, 2016-02-09 23:57:33]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2016-02-09 23:59:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1683863002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1683863002/40001

[commit-bot: I haz the power, 2016-02-10 01:08:38]

Description was changed from

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
==========

to

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
==========

[commit-bot: I haz the power, 2016-02-10 01:08:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-10 01:09:26]

Description was changed from

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738
==========

to

==========
Mojo C++ bindings: make mojo::Map<K,V> more friendly with std::map<K,V>.

This CL:
- removes a hack that handles move-only elements before C++11 support.
  With this change the underlying storage of mojo::Map<K,V> is always
  std::map<K,V>.
- adds "Map(std::map<K,V>&&)".
- adds "const std::map<K,V>& storage() const".
- adds "std::map<K,V> PassStorage()".
- removes the home-made ConstMapIterator; uses std::map<K,V>::const_iterator
  instead.

BUG=583738

Committed: https://crrev.com/eb03d056f6f1535b78a9efce05898c4398d9d51c
Cr-Commit-Position: refs/heads/master@{#374559}
==========

[commit-bot: I haz the power, 2016-02-10 01:09:27]

Patchset 3 (id:??) landed as
https://crrev.com/eb03d056f6f1535b78a9efce05898c4398d9d51c
Cr-Commit-Position: refs/heads/master@{#374559}