Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1683853003: Revert of ash/mash: Add a mus-client that sets up ash to provide the system ui for mash. (Closed)

Created:
4 years, 10 months ago by iclelland
Modified:
4 years, 10 months ago
Reviewers:
sadrul, sky, vmpstr
CC:
chromium-reviews, kalyank, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ash/mash: Add a mus-client that sets up ash to provide the system ui for mash. (patchset #5 id:80001 of https://codereview.chromium.org/1676713002/ ) Reason for revert: This CL is breaking the build. See https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN%20%28dbg%29/builds/17919 The linker error is [1834/2095] SOLINK ./libash_sysui_library.so FAILED: python "/b/build/slave/Linux_ChromiumOS_GN__dbg_/build/src/build/toolchain/gcc_solink_wrapper.py" --readelf="readelf" --nm="nm" --sofile="./libash_sysui_library.so" --tocfile="./libash_sysui_library.so.TOC" --output="./libash_sysui_library.so" -- ../../third_party/llvm-build/Release+Asserts/bin/clang++ -shared -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=all -pthread -m64 -Wl,--export-dynamic -o "./libash_sysui_library.so" -Wl,-soname="libash_sysui_library.so" @"./libash_sysui_library.so.rsp" ../../ash/mus/shell_delegate_mus.cc:23: error: undefined reference to 'user_manager::UserInfoImpl::UserInfoImpl()' ../../ash/mus/sysui_application.cc:126: error: undefined reference to 'message_center::MessageCenter::Initialize()' clang: error: linker command failed with exit code 1 (use -v to see invocation) ninja: build stopped: subcommand failed. Original issue's description: > ash/mash: Add a mus-client that sets up ash to provide the system ui for mash. > > We only want a small number of the components of ash (e.g. shelf, wallpaper, > system-tray, app-list) etc. for mash, but for now, the mus-client loads all of > ash. The bare minimum set of delegates have stub implementations. These will > grow as we hook them up with other mojo/mus services. > > BUG=585141 > > Committed: https://crrev.com/dfd7833ae942a8339853ed02907bb31e0806badc > Cr-Commit-Position: refs/heads/master@{#374470} TBR=sky@chromium.org,vmpstr@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=585141 Committed: https://crrev.com/b7259b7d8718e0235212d441b85f2bab9970a68f Cr-Commit-Position: refs/heads/master@{#374483}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -794 lines) Patch
M ash/host/ash_window_tree_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/host/ash_window_tree_host.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M ash/host/ash_window_tree_host_platform.h View 1 chunk +2 lines, -4 lines 0 comments Download
D ash/mus/BUILD.gn View 1 chunk +0 lines, -53 lines 0 comments Download
D ash/mus/DEPS View 1 chunk +0 lines, -13 lines 0 comments Download
D ash/mus/main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
D ash/mus/shell_delegate_mus.h View 1 chunk +0 lines, -63 lines 0 comments Download
D ash/mus/shell_delegate_mus.cc View 1 chunk +0 lines, -204 lines 0 comments Download
D ash/mus/stub_context_factory.h View 1 chunk +0 lines, -52 lines 0 comments Download
D ash/mus/stub_context_factory.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D ash/mus/sysui_application.h View 1 chunk +0 lines, -38 lines 0 comments Download
D ash/mus/sysui_application.cc View 1 chunk +0 lines, -183 lines 0 comments Download
M ash/root_window_settings.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/snap_to_pixel_layout_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M mash/shell/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M mash/shell/shell_application_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M mash/shell/shell_application_delegate.cc View 3 chunks +2 lines, -21 lines 0 comments Download
M ui/base/user_activity/user_activity_detector.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 4 chunks +2 lines, -4 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 6 chunks +18 lines, -24 lines 0 comments Download
M ui/views/mus/window_manager_connection.h View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 3 chunks +12 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
iclelland
Created Revert of ash/mash: Add a mus-client that sets up ash to provide the system ...
4 years, 10 months ago (2016-02-09 21:45:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683853003/1
4 years, 10 months ago (2016-02-09 21:49:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 21:53:09 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-09 21:54:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7259b7d8718e0235212d441b85f2bab9970a68f
Cr-Commit-Position: refs/heads/master@{#374483}

Powered by Google App Engine
This is Rietveld 408576698