Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 1683843006: Remove the 0.5 bias from the ellipse edge function. This makes coverage drop to zero before we get … (Closed)

Created:
4 years, 10 months ago by Brian Osman
Modified:
4 years, 10 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove the 0.5 bias from the ellipse edge function. This makes coverage drop to zero before we get clipped by the rasterizer (i.e. ensures the generated ellipse is inscribed in the geometry). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1683843006 Committed: https://skia.googlesource.com/skia/+/09bf666233bdb5e4e08bbeba2030055bc3bdef5f

Patch Set 1 #

Patch Set 2 : Oops, removing debugging code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/gpu/GrOvalRenderer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Brian Osman
4 years, 10 months ago (2016-02-11 20:46:04 UTC) #4
jvanverth1
lgtm
4 years, 10 months ago (2016-02-12 14:58:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683843006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683843006/20001
4 years, 10 months ago (2016-02-12 15:16:50 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 15:46:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/09bf666233bdb5e4e08bbeba2030055bc3bdef5f

Powered by Google App Engine
This is Rietveld 408576698