Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1683823002: Revert of Make instrumentation_test_apk depend on their apk_under_test. (Closed)

Created:
4 years, 10 months ago by iclelland
Modified:
4 years, 10 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@dist-jar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make instrumentation_test_apk depend on their apk_under_test. (patchset #2 id:20001 of https://codereview.chromium.org/1677903002/ ) Reason for revert: Build is broken: compile Revision range: chromium 374412 : 374420 Failing builders: Android GN (dbg): https://build.chromium.org/p/chromium.linux/builders/Android%20GN%20(dbg) Appears to be caused by crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab This didn't cause failures immediately; I suspect that it took a DEPS update to cause a full build before the offending APK was a problem Original issue's description: > Make instrumentation_test_apk depend on their apk_under_test. > > The test runner tries to install the apk_under_test, so it makes sense > that building the test should also build the apk_under_test. > > BUG=none > > Committed: https://crrev.com/6c2fbb438add5f31cd9d37e580c4735a4c7becab > Cr-Commit-Position: refs/heads/master@{#374402} TBR=jbudorick@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/fc37513b69d48a1b076febe2952d74fe9596cecd Cr-Commit-Position: refs/heads/master@{#374448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
iclelland
Created Revert of Make instrumentation_test_apk depend on their apk_under_test.
4 years, 10 months ago (2016-02-09 20:13:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683823002/1
4 years, 10 months ago (2016-02-09 20:16:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-09 20:21:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fc37513b69d48a1b076febe2952d74fe9596cecd Cr-Commit-Position: refs/heads/master@{#374448}
4 years, 10 months ago (2016-02-09 20:23:17 UTC) #6
agrieve
4 years, 10 months ago (2016-02-10 01:45:12 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1687723002/ by agrieve@chromium.org.

The reason for reverting is: going to reland with fix.

Powered by Google App Engine
This is Rietveld 408576698