Fix summarization of generic redirecting constructors (again).

Fix summarization of generic redirecting constructors (again).

In the previous fix (4b5d30abba9d1082c8bc70ffa5255ae6ef9b52d0) I
neglected to account for the fact that
ConstructorElement.redirectedConstructor is sometimes a
ConstructorMember, not a ConstructorElementImpl.

Fixing this required properly storing the redirected constructor's
type arguments in the summary.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/1f4d5390b91ef6b133f9f7401509844e736974cd

[Paul Berry, 2016-02-10 20:23:01]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2016-02-10 20:37:53]

LGTM

https://codereview.chromium.org/1683813005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1683813005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:587: * [_definingType],
[displayName], [enclosingElement] and [name] can be used
Maybe we should exclude "_definingType" from the list.
It has never actually overridden any property of the superclass.

[Paul Berry, 2016-02-10 20:54:36]

https://codereview.chromium.org/1683813005/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1683813005/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:587: * [_definingType],
[displayName], [enclosingElement] and [name] can be used
On 2016/02/10 20:37:53, scheglov wrote:
> Maybe we should exclude "_definingType" from the list.
> It has never actually overridden any property of the superclass.

Done.

[Paul Berry, 2016-02-10 20:55:14]

Description was changed from

==========
Fix summarization of generic redirecting constructors (again).

In the previous fix (4b5d30abba9d1082c8bc70ffa5255ae6ef9b52d0) I
neglected to account for the fact that
ConstructorElement.redirectedConstructor is sometimes a
ConstructorMember, not a ConstructorElementImpl.

Fixing this required properly storing the redirected constructor's
type arguments in the summary.
==========

to

==========
Fix summarization of generic redirecting constructors (again).

In the previous fix (4b5d30abba9d1082c8bc70ffa5255ae6ef9b52d0) I
neglected to account for the fact that
ConstructorElement.redirectedConstructor is sometimes a
ConstructorMember, not a ConstructorElementImpl.

Fixing this required properly storing the redirected constructor's
type arguments in the summary.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1f4d5390b91ef6b133f9f7401509844e736974cd
==========

[Paul Berry, 2016-02-10 20:55:16]

Committed patchset #1 (id:1) manually as
1f4d5390b91ef6b133f9f7401509844e736974cd (presubmit successful).