Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 16838013: Revert "Notify CPU profiler when calling native getters" (Closed)

Created:
7 years, 6 months ago by yurys
Modified:
7 years, 6 months ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Revert "Notify CPU profiler when calling native getters" This reverts commit f323d984a73bab345c4eab5c1907552ccfa7ccaa. Broke compilation on the bots with an error that doesn't occur locally: CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-bignum-dtoa.o ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = int]’: ../test/cctest/test-api.cc:1129: error: insufficient contextual information to determine type ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = unsigned int]’: ../test/cctest/test-api.cc:1136: error: insufficient contextual information to determine type ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = double]’: ../test/cctest/test-api.cc:1143: error: insufficient contextual information to determine type ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = bool]’: ../test/cctest/test-api.cc:1150: error: insufficient contextual information to determine type ../test/cctest/test-api.cc: In function ‘void FastReturnValueCallback(const v8::FunctionCallbackInfo<v8::Value>&) [with T = void]’: ../test/cctest/test-api.cc:1157: error: insufficient contextual information to determine type CXX(target) /mnt/data/b/build/slave/v8-linux-debug/build/v8/out/Debug/obj.target/cctest/test/cctest/test-circular-queue.o BUG=None TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -591 lines) Patch
M src/api.h View 1 chunk +0 lines, -18 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M src/arm/code-stubs-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 2 chunks +1 line, -24 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +2 lines, -63 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +1 line, -29 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -19 lines 0 comments Download
M src/cpu-profiler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +7 lines, -26 lines 0 comments Download
M src/mips/code-stubs-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 2 chunks +1 line, -23 lines 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +0 lines, -55 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 4 chunks +1 line, -32 lines 0 comments Download
M src/sampler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 4 chunks +0 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 26 chunks +96 lines, -174 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yurys
7 years, 6 months ago (2013-06-13 14:04:45 UTC) #1
yurys
Committed patchset #1 manually as r15117 (presubmit successful).
7 years, 6 months ago (2013-06-13 14:05:45 UTC) #2
Sven Panne
7 years, 6 months ago (2013-06-14 08:12:38 UTC) #3
Message was sent while issue was closed.
LGTM (rubber-stamped)

Powered by Google App Engine
This is Rietveld 408576698