Ensure real GL Api is set before making GL calls.

Ensure real GL Api is set before making GL calls.

In particular IOSurfaceImageTransportSurface::OnMakeCurrent()
calls into GL.

BUG=248957
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206103

[greggman, 2013-06-12 22:17:18]

https://codereview.chromium.org/16838007/diff/1/ui/gl/gl_context_cgl.cc
File ui/gl/gl_context_cgl.cc (right):

https://codereview.chromium.org/16838007/diff/1/ui/gl/gl_context_cgl.cc#newco...
ui/gl/gl_context_cgl.cc:190: SetRealGLApi();
Do you want to restore it if it fails?

I know that's a lot of refactoring but it seems like if it fails at line 193 or
like 198 then the previous RealGLApi should still be restored

Either that or it should be set to NULL so that if anyone is not checking the
results from MakeCurrent they'll fail rather than trashing someone else's
context.

What do you think?

[greggman, 2013-06-12 22:26:54]

lgtm.

please file an issue to clean up the failure paths.

We should probably discuss if they should set the RealGLApi to NULL or restore
the old one.

[commit-bot: I haz the power, 2013-06-12 22:34:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/16838007/1

[no sievers, 2013-06-12 23:35:28]

On 2013/06/12 22:26:54, greggman wrote:
> lgtm.
> 
> please file an issue to clean up the failure paths.
> 

https://codereview.chromium.org/16894002/


> We should probably discuss if they should set the RealGLApi to NULL or restore
> the old one.

[commit-bot: I haz the power, 2013-06-13 03:17:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/16838007/1

[commit-bot: I haz the power, 2013-06-13 06:37:58]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-06-13 15:01:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/16838007/1

[commit-bot: I haz the power, 2013-06-13 17:31:46]

Change committed as 206103