Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1683783002: Add registerNodeListWithIdNameCache() assert. (Closed)

Created:
4 years, 10 months ago by sof
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add registerNodeListWithIdNameCache() assert. Follow up r374385 and catch out unsupported multiple registrations. R=haraken BUG=585054 Committed: https://crrev.com/186baa158c7e7eadeb646adf21cf8a3e608d4ba3 Cr-Commit-Position: refs/heads/master@{#374614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look. need to enforce the no-duplicates invariant there also.
4 years, 10 months ago (2016-02-09 21:57:07 UTC) #2
haraken
LGTM
4 years, 10 months ago (2016-02-10 00:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1683783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1683783002/1
4 years, 10 months ago (2016-02-10 06:19:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-10 06:53:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-10 06:54:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/186baa158c7e7eadeb646adf21cf8a3e608d4ba3
Cr-Commit-Position: refs/heads/master@{#374614}

Powered by Google App Engine
This is Rietveld 408576698