include/core/SkFixed.h - Issue 1683743005: Simple cleanups related to SkFixed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkFixed.h

Issue 1683743005: Simple cleanups related to SkFixed. (Closed) Base URL: https://skia.googlesource.com/skia@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkFixed.h

diff --git a/include/core/SkFixed.h b/include/core/SkFixed.h

index f6dd3d60020207382e3f9bdf238bde5a0ba8955c..51fffce8b65c67f46c58189dcc56eac91bc74789 100644

--- a/include/core/SkFixed.h

+++ b/include/core/SkFixed.h

@@ -21,8 +21,7 @@ typedef int32_t SkFixed;

#define SK_Fixed1 (1 << 16)

#define SK_FixedHalf (1 << 15)

#define SK_FixedMax (0x7FFFFFFF)

-#define SK_FixedMin (-SK_FixedMax)

-#define SK_FixedNaN ((int) 0x80000000)

+#define SK_FixedMin (0x80000000)

reed1 2016/02/11 21:43:44 Why this change?

dogben 2016/02/11 21:53:13 Because it seemed odd to me that for some x, SkSca

reed1 2016/02/11 22:22:59 I think its wacky either way: Now we have -SK_Fixe

#define SK_FixedPI (0x3243F)

#define SK_FixedSqrt2 (92682)

#define SK_FixedTanPIOver8 (0x6A0A)

« no previous file with comments | « no previous file | include/core/SkRect.h » ('j') | src/core/SkPaint.cpp » ('J')