Issue 168373002: Make the #includes consistent in various thread checkers between debug and release mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 168373002: Make the #includes consistent in various thread checkers between debug and release mode. (Closed)

Created:
6 years, 10 months ago by Lei Zhang

Modified:
6 years, 10 months ago

Reviewers:
brettw

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Make the #includes consistent in various thread checkers between debug and release mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251595

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -12 lines)			Patch
M	base/sequence_checker.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	base/threading/non_thread_safe.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	base/threading/thread_checker.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Lei Zhang

Several people, including myself, have hit missing #include build failures on the build bots in ...

6 years, 10 months ago (2014-02-15 05:21:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/168373002/1

6 years, 10 months ago (2014-02-15 19:06:35 UTC) #4

Message was sent while issue was closed.

Change committed as 251595