Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: net/disk_cache/addr.cc

Issue 16837003: Disk cache: Update Addr to handle file format version 3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/disk_cache/addr.h ('k') | net/disk_cache/addr_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/addr.cc
===================================================================
--- net/disk_cache/addr.cc (revision 205902)
+++ net/disk_cache/addr.cc (working copy)
@@ -26,22 +26,35 @@
return true;
}
-bool Addr::SanityCheck() const {
+bool Addr::SanityCheckV2() const {
if (!is_initialized())
return !value_;
- if (((value_ & kFileTypeMask) >> kFileTypeOffset) > 4)
+ if (file_type() > BLOCK_4K)
return false;
if (is_separate_file())
return true;
- const uint32 kReservedBitsMask = 0x0c000000;
- return !(value_ & kReservedBitsMask);
+ return !reserved_bits();
}
+bool Addr::SanityCheckV3() const {
+ if (!is_initialized())
+ return !value_;
+
+ // For actual entries, SanityCheckForEntryV3 should be used.
+ if (file_type() > BLOCK_FILES)
+ return false;
+
+ if (is_separate_file())
+ return true;
+
+ return !reserved_bits();
+}
+
bool Addr::SanityCheckForEntryV2() const {
- if (!SanityCheck() || !is_initialized())
+ if (!SanityCheckV2() || !is_initialized())
return false;
if (is_separate_file() || file_type() != BLOCK_256)
@@ -50,8 +63,24 @@
return true;
}
+bool Addr::SanityCheckForEntryV3() const {
+ if (!is_initialized())
+ return false;
+
+ if (reserved_bits())
+ return false;
+
+ if (file_type() != BLOCK_ENTRIES && file_type() != BLOCK_EVICTED)
+ return false;
+
+ if (num_blocks() != 1)
+ return false;
+
+ return true;
+}
+
bool Addr::SanityCheckForRankings() const {
- if (!SanityCheck() || !is_initialized())
+ if (!SanityCheckV2() || !is_initialized())
return false;
if (is_separate_file() || file_type() != RANKINGS || num_blocks() != 1)
« no previous file with comments | « net/disk_cache/addr.h ('k') | net/disk_cache/addr_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698